I actually tried to compile this on Windows, but was unsuccessful. I guess the only way to test it would be with a linux environment. Sorry for the trouble, but hopefully this at least saves you some of the gruntwork.
$ diff llvm-project/libcxxabi/src/demangle/StringView.h llvm-project/llvm/lib/Demangle/StringView.h gives a bunch of junk, I used to be able to just use a script that basically called patch to copy the bulk of the changes over. Did you call clang-format or something?
I think this is fine though, so after deformatting and adding that include feel free to commit!
|23 ↗||(On Diff #156384)|
This depends on __cxxabi_config.h to make sure that __has_attribute is defined on compilers that don't support it. Please add the include.
Yea, it's fine either way. I was just looking at it from the perspective
of minimizing differences from the master copy in LLVM. Definitely having
headers be self-contained is worthy, but it comes at the (very small)
expense of adding an extra difference from the master copy. That said, I
don't feel strongly, so if you want me to add it, that's fine.