Page MenuHomePhabricator

Smeenai's D35077 Requests

Authored by bhelyer on Jul 18 2018, 3:04 AM.



So I have no idea what I'm doing with Phabricator, and I have no idea how to update the previous request. I chose 'update diff' and made a new one, and I don't see a way to delete it, so here we are. I apologise for the noise, but now that we're here...

This update to the diff attempts to hit all of @smeenai's requests. In order:

  • LLVM_BUILD_LLVM_C_DYLIB defaults to off on windows, and the comment is gone
  • Parens are used to make clear what's going on in the complicated if statement.
  • The "always build on windows" comment has been removed, as it is no longer true.
  • The python script now takes an --underscore flag, rather than an arch, and --underscore is only set on x86.
  • llvm-nm -g is now used instead of dumpbin /linkermember:1.

I've built the DLL on 64 bit, and it seems to be correct. Still need to test 32 bit, and make sure nothing is amiss on non-windows platforms. If this needs to be folded into the D35077 differential, I'll need some pointers on how to do so. Thanks, and sorry again!

Diff Detail

Event Timeline

bhelyer created this revision.Jul 18 2018, 3:04 AM
bhelyer edited the summary of this revision. (Show Details)Jul 18 2018, 3:14 AM
bhelyer added reviewers: smeenai, hans, Wallbraker.
bhelyer added subscribers: smeenai, bhelyer.
bhelyer updated this revision to Diff 156224.EditedJul 19 2018, 3:08 AM

Upon building the 32 bit DLL, I discovered the way I was detecting host architecture was wrong. Checking LLVM_HOST_TRIPLE works on both 64 and 32 bit builds, but let me know if there's a better way of figuring this stuff out from cmake.

Also I see I can attach this diff fine, so apparently you can only update your own requests? I can get Jakob to submit the patch over there (or some kind of admin could do it?) if keeping everything over there is important.

bhelyer abandoned this revision.Aug 7 2018, 11:07 PM

These changes have been merged up into Jakob's original revision, so closing this one now.