This is an archive of the discontinued LLVM Phabricator instance.

[CMake] Fix a typo in the variable used to retrieve source file names for the `RTHwasan_dynamic` target.
ClosedPublic

Authored by delcypher on Jul 11 2018, 6:02 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

delcypher created this revision.Jul 11 2018, 6:02 AM
Herald added subscribers: Restricted Project, mgorny. · View Herald TranscriptJul 11 2018, 6:02 AM

@eugenis Could you test this? HWAsan doesn't build on macOS right now so I can't test it. I spotted this typo when doing a recent change so I though I'd send a patch your way.

george.karpenkov resigned from this revision.Jul 11 2018, 2:31 PM
eugenis accepted this revision.Jul 12 2018, 10:47 AM

Thanks, this is correct, this change adds operators new and delete to the library. Does not affect any of the existing tests: hwasan does not have new/malloc/free/delete mismatch checking yet.
LGTM.

This revision is now accepted and ready to land.Jul 12 2018, 10:47 AM
This revision was automatically updated to reflect the committed changes.