Page MenuHomePhabricator

Pass expressions instead of argument ranges to EmitCall/EmitCXXConstructorCall.
ClosedPublic

Authored by samsonov on Aug 14 2014, 2:54 PM.

Details

Summary

This is a first small step towards passing generic "Expr" instead of
ArgBeg/ArgEnd pair into EmitCallArgs() family of methods. Having "Expr" will
allow us to get the corresponding FunctionDecl and its ParmVarDecls,
thus allowing us to alter CodeGen depending on the function/parameter
attributes.

No functionality change.

Diff Detail

Event Timeline

samsonov updated this revision to Diff 12526.Aug 14 2014, 2:54 PM
samsonov retitled this revision from to Pass expressions instead of argument ranges to EmitCall/EmitCXXConstructorCall..
samsonov updated this object.
samsonov edited the test plan for this revision. (Show Details)
samsonov added a reviewer: rnk.
samsonov added a subscriber: Unknown Object (MLST).
rnk accepted this revision.Aug 21 2014, 11:18 AM
rnk edited edge metadata.

lgtm

Passing the CallExpr seems like an improvement over passing CallExpr-specific iterator types.

This revision is now accepted and ready to land.Aug 21 2014, 11:18 AM
samsonov closed this revision.Aug 21 2014, 1:35 PM