Index: llvm/trunk/unittests/Transforms/Vectorize/VPlanHCFGTest.cpp =================================================================== --- llvm/trunk/unittests/Transforms/Vectorize/VPlanHCFGTest.cpp +++ llvm/trunk/unittests/Transforms/Vectorize/VPlanHCFGTest.cpp @@ -8,35 +8,16 @@ //===----------------------------------------------------------------------===// #include "../lib/Transforms/Vectorize/VPlan.h" -#include "../lib/Transforms/Vectorize/VPlanHCFGBuilder.h" #include "../lib/Transforms/Vectorize/VPlanHCFGTransforms.h" -#include "llvm/AsmParser/Parser.h" -#include "llvm/IR/Dominators.h" +#include "VPlanTestBase.h" #include "gtest/gtest.h" namespace llvm { namespace { -class VPlanHCFGTest : public testing::Test { -protected: - std::unique_ptr DT; - std::unique_ptr LI; - - VPlanHCFGTest() {} - - VPlanPtr doBuildPlan(BasicBlock *LoopHeader) { - DT.reset(new DominatorTree(*LoopHeader->getParent())); - LI.reset(new LoopInfo(*DT)); - - auto Plan = llvm::make_unique(); - VPlanHCFGBuilder HCFGBuilder(LI->getLoopFor(LoopHeader), LI.get()); - HCFGBuilder.buildHierarchicalCFG(*Plan.get()); - return Plan; - } -}; +class VPlanHCFGTest : public VPlanTestBase {}; TEST_F(VPlanHCFGTest, testBuildHCFGInnerLoop) { - LLVMContext Ctx; const char *ModuleString = "define void @f(i32* %A, i64 %N) {\n" "entry:\n" @@ -54,12 +35,11 @@ " ret void\n" "}\n"; - SMDiagnostic Err; - std::unique_ptr M = parseAssemblyString(ModuleString, Err, Ctx); + Module &M = parseModule(ModuleString); - Function *F = M->getFunction("f"); + Function *F = M.getFunction("f"); BasicBlock *LoopHeader = F->getEntryBlock().getSingleSuccessor(); - auto Plan = doBuildPlan(LoopHeader); + auto Plan = buildHCFG(LoopHeader); VPBasicBlock *Entry = Plan->getEntry()->getEntryBasicBlock(); EXPECT_NE(nullptr, Entry->getSingleSuccessor()); @@ -115,7 +95,6 @@ } TEST_F(VPlanHCFGTest, testVPInstructionToVPRecipesInner) { - LLVMContext Ctx; const char *ModuleString = "define void @f(i32* %A, i64 %N) {\n" "entry:\n" @@ -133,12 +112,11 @@ " ret void\n" "}\n"; - SMDiagnostic Err; - std::unique_ptr M = parseAssemblyString(ModuleString, Err, Ctx); + Module &M = parseModule(ModuleString); - Function *F = M->getFunction("f"); + Function *F = M.getFunction("f"); BasicBlock *LoopHeader = F->getEntryBlock().getSingleSuccessor(); - auto Plan = doBuildPlan(LoopHeader); + auto Plan = buildHCFG(LoopHeader); LoopVectorizationLegality::InductionList Inductions; SmallPtrSet DeadInstructions; Index: llvm/trunk/unittests/Transforms/Vectorize/VPlanTestBase.h =================================================================== --- llvm/trunk/unittests/Transforms/Vectorize/VPlanTestBase.h +++ llvm/trunk/unittests/Transforms/Vectorize/VPlanTestBase.h @@ -0,0 +1,68 @@ +//===- llvm/unittest/Transforms/Vectorize/VPlanTestBase.h -----------------===// +// +// The LLVM Compiler Infrastructure +// +// This file is distributed under the University of Illinois Open Source +// License. See LICENSE.TXT for details. +// +//===----------------------------------------------------------------------===// +/// \file +/// This file defines a VPlanTestBase class, which provides helpers to parse +/// a LLVM IR string and create VPlans given a loop entry block. +//===----------------------------------------------------------------------===// +#ifndef LLVM_UNITTESTS_TRANSFORMS_VECTORIZE_VPLANTESTBASE_H +#define LLVM_UNITTESTS_TRANSFORMS_VECTORIZE_VPLANTESTBASE_H + +#include "../lib/Transforms/Vectorize/VPlan.h" +#include "../lib/Transforms/Vectorize/VPlanHCFGBuilder.h" +#include "llvm/Analysis/LoopInfo.h" +#include "llvm/AsmParser/Parser.h" +#include "llvm/IR/Dominators.h" +#include "llvm/Support/SourceMgr.h" +#include "gtest/gtest.h" + +namespace llvm { + +/// Helper class to create a module from an assembly string and VPlans for a +/// given loop entry block. +class VPlanTestBase : public testing::Test { +protected: + std::unique_ptr DT; + std::unique_ptr LI; + std::unique_ptr M; + std::unique_ptr Ctx; + + VPlanTestBase() : Ctx(new LLVMContext) {} + ~VPlanTestBase() { + LI.release(); + DT.release(); + M.release(); + // We need to release objects depending on Ctx first. + Ctx.release(); + } + + Module &parseModule(const char *ModuleString) { + SMDiagnostic Err; + M = parseAssemblyString(ModuleString, Err, *Ctx); + EXPECT_TRUE(M); + return *M; + } + + void doAnalysis(Function &F) { + DT.reset(new DominatorTree(F)); + LI.reset(new LoopInfo(*DT)); + } + + VPlanPtr buildHCFG(BasicBlock *LoopHeader) { + doAnalysis(*LoopHeader->getParent()); + + auto Plan = llvm::make_unique(); + VPlanHCFGBuilder HCFGBuilder(LI->getLoopFor(LoopHeader), LI.get()); + HCFGBuilder.buildHierarchicalCFG(*Plan.get()); + return Plan; + } +}; + +} // namespace llvm + +#endif // LLVM_UNITTESTS_TRANSFORMS_VECTORIZE_VPLANTESTBASE_H