This is an archive of the discontinued LLVM Phabricator instance.

[OMPT] Add synchronization to threads_nested.c testcase
ClosedPublic

Authored by sconvent on Jul 4 2018, 5:31 AM.

Reviewers

Commits

Summary

As @protze.joachim pointed out in D47824 , the testcase may fail when a thread is reused.
The added synchronization makes sure this does not happen.

LGTM

This revision is now accepted and ready to land.Jul 5 2018, 2:13 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

openmp/

trunk/

runtime/

test/

ompt/

misc/

6 lines

	// RUN: %libomp-compile-and-run \| %sort-threads \| FileCheck %s			// RUN: %libomp-compile-and-run \| %sort-threads \| FileCheck %s
	// REQUIRES: ompt			// REQUIRES: ompt
	#include "callback.h"			#include "callback.h"
	#include <omp.h>			#include <omp.h>

	int main() {			int main() {

				int condition = 0;
	int x = 0;			int x = 0;
	omp_set_nested(1);			omp_set_nested(1);
	#pragma omp parallel num_threads(2)			#pragma omp parallel num_threads(2)
	{			{
	#pragma omp parallel num_threads(2)			#pragma omp parallel num_threads(2)
	{			{
	#pragma omp atomic			OMPT_SIGNAL(condition);
	x++;			OMPT_WAIT(condition, 4);
	}			}
	}			}

	// CHECK: 0: NULL_POINTER=[[NULL:.*$]]			// CHECK: 0: NULL_POINTER=[[NULL:.*$]]

	// CHECK: {{^}}[[MASTER_ID:[0-9]+]]: ompt_event_thread_begin:			// CHECK: {{^}}[[MASTER_ID:[0-9]+]]: ompt_event_thread_begin:
	// CHECK-SAME: thread_type=ompt_thread_initial=1, thread_id=[[MASTER_ID]]			// CHECK-SAME: thread_type=ompt_thread_initial=1, thread_id=[[MASTER_ID]]
	// CHECK: {{^}}[[MASTER_ID]]: ompt_event_thread_end:			// CHECK: {{^}}[[MASTER_ID]]: ompt_event_thread_end:
	Show All 16 Lines