Index: lldb/source/Target/ExecutionContext.cpp =================================================================== --- lldb/source/Target/ExecutionContext.cpp +++ lldb/source/Target/ExecutionContext.cpp @@ -183,9 +183,9 @@ lldb::ByteOrder ExecutionContext::GetByteOrder() const { if (m_target_sp && m_target_sp->GetArchitecture().IsValid()) - m_target_sp->GetArchitecture().GetByteOrder(); + return m_target_sp->GetArchitecture().GetByteOrder(); if (m_process_sp) - m_process_sp->GetByteOrder(); + return m_process_sp->GetByteOrder(); return endian::InlHostByteOrder(); } Index: lldb/unittests/Target/CMakeLists.txt =================================================================== --- lldb/unittests/Target/CMakeLists.txt +++ lldb/unittests/Target/CMakeLists.txt @@ -1,4 +1,5 @@ add_lldb_unittest(TargetTests + ExecutionContextTest.cpp MemoryRegionInfoTest.cpp ModuleCacheTest.cpp PathMappingListTest.cpp @@ -7,10 +8,11 @@ LINK_LIBS lldbCore lldbHost - lldbSymbol - lldbUtility lldbPluginObjectFileELF + lldbPluginPlatformLinux lldbPluginSymbolFileSymtab + lldbSymbol + lldbUtility lldbUtilityHelpers LINK_COMPONENTS Support Index: lldb/unittests/Target/ExecutionContextTest.cpp =================================================================== --- /dev/null +++ lldb/unittests/Target/ExecutionContextTest.cpp @@ -0,0 +1,125 @@ +//===-- ExecutionContextTest.cpp --------------------------------*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception +// +//===----------------------------------------------------------------------===// + +#include "lldb/Target/ExecutionContext.h" +#include "Plugins/Platform/Linux/PlatformLinux.h" +#include "lldb/Core/Debugger.h" +#include "lldb/Host/FileSystem.h" +#include "lldb/Host/HostInfo.h" +#include "lldb/Target/Platform.h" +#include "lldb/Target/Process.h" +#include "lldb/Target/Target.h" +#include "lldb/Utility/ArchSpec.h" +#include "lldb/Utility/Endian.h" +#include "lldb/Utility/Reproducer.h" +#include "lldb/lldb-enumerations.h" +#include "lldb/lldb-forward.h" +#include "lldb/lldb-private-enumerations.h" +#include "lldb/lldb-private.h" +#include "llvm/Support/FormatVariadic.h" +#include "gtest/gtest.h" + +using namespace lldb_private; +using namespace lldb_private::repro; +using namespace lldb; + +class ExecutionContextTest : public ::testing::Test { +public: + void SetUp() override { + llvm::cantFail(Reproducer::Initialize(ReproducerMode::Off, llvm::None)); + FileSystem::Initialize(); + HostInfo::Initialize(); + platform_linux::PlatformLinux::Initialize(); + } + void TearDown() override { + HostInfo::Terminate(); + FileSystem::Terminate(); + Reproducer::Terminate(); + platform_linux::PlatformLinux::Terminate(); + } +}; + +class DummyProcess : public Process { +public: + using Process::Process; + + virtual bool CanDebug(lldb::TargetSP target, bool plugin_specified_by_name) { + return true; + } + virtual Status DoDestroy() { return {}; } + virtual void RefreshStateAfterStop() {} + + virtual size_t DoReadMemory(lldb::addr_t vm_addr, void *buf, size_t size, + Status &error) { + return 0; + } + + virtual bool UpdateThreadList(ThreadList &old_thread_list, + ThreadList &new_thread_list) { + return false; + } + + virtual ConstString GetPluginName() { return ConstString("Dummy"); } + virtual uint32_t GetPluginVersion() { return 0; } +}; + +TEST_F(ExecutionContextTest, GetByteOrder) { + ExecutionContext exe_ctx(nullptr, nullptr, nullptr); + EXPECT_EQ(endian::InlHostByteOrder(), exe_ctx.GetByteOrder()); +} + +TEST_F(ExecutionContextTest, GetByteOrderTarget) { + ArchSpec arch = Target::GetDefaultArchitecture(); + arch.SetTriple("armv7-pc-apple"); + + PlatformSP platform = + platform_linux::PlatformLinux::CreateInstance(true, &arch); + Platform::SetHostPlatform(platform); + + DebuggerSP debugger_sp = Debugger::CreateInstance(); + EXPECT_TRUE(debugger_sp); + + TargetSP target_sp; + PlatformSP platform_sp; + Status error = debugger_sp->GetTargetList().CreateTarget( + *debugger_sp, "", arch, eLoadDependentsNo, platform_sp, target_sp); + EXPECT_TRUE(target_sp); + EXPECT_TRUE(target_sp->GetArchitecture().IsValid()); + EXPECT_TRUE(platform_sp); + + ExecutionContext target_ctx(target_sp, false); + EXPECT_EQ(target_sp->GetArchitecture().GetByteOrder(), + target_ctx.GetByteOrder()); +} + +TEST_F(ExecutionContextTest, GetByteOrderProcess) { + ArchSpec arch = Target::GetDefaultArchitecture(); + arch.SetTriple("armv7-pc-apple"); + + PlatformSP platform = + platform_linux::PlatformLinux::CreateInstance(true, &arch); + Platform::SetHostPlatform(platform); + + DebuggerSP debugger_sp = Debugger::CreateInstance(); + EXPECT_TRUE(debugger_sp); + + TargetSP target_sp; + PlatformSP platform_sp; + Status error = debugger_sp->GetTargetList().CreateTarget( + *debugger_sp, "", arch, eLoadDependentsNo, platform_sp, target_sp); + EXPECT_TRUE(target_sp); + EXPECT_TRUE(target_sp->GetArchitecture().IsValid()); + EXPECT_TRUE(platform_sp); + + ListenerSP listener_sp(Listener::MakeListener("dummy")); + ProcessSP process_sp = std::make_shared(target_sp, listener_sp); + EXPECT_TRUE(process_sp); + + ExecutionContext process_ctx(process_sp); + EXPECT_EQ(process_sp->GetByteOrder(), process_ctx.GetByteOrder()); +}