This is an archive of the discontinued LLVM Phabricator instance.

[libFuzzer] [NFC] [Tests] Drop -O2 from configuration
AbandonedPublic

Authored by george.karpenkov on Jun 27 2018, 6:20 PM.

Details

Summary

Currently we add -O2 in the lit.cfg for libFuzzer: https://github.com/llvm-mirror/compiler-rt/blob/master/test/fuzzer/lit.cfg#L74

However, the latest revision of the patch by Matt [which originally added that line] did not have that in the latest iteration (https://reviews.llvm.org/D44798).

It looks like it crept in as a result of a merge conflict, and should be dropped.

Diff Detail

Event Timeline

Does not seem to affect the fuzzing time.

kcc added a comment.Jun 27 2018, 6:24 PM

Hm... I thought this is intentional -- I do want to test libFuzzer with O2 by default.
Matt?

@kcc That's what I've thought, but it seems it got removed in the latest revision in favor of an LLVM attribute, and then re-introduced [?]

We want to keep -O2.

I think arcanist was just acting up... Actual committed changes: https://reviews.llvm.org/rCRT328384