This is an archive of the discontinued LLVM Phabricator instance.

Added test case for: r334978 - Fixed file completion for paths that start with '~'
ClosedPublic

Authored by teemperor on Jun 27 2018, 11:37 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

teemperor created this revision.Jun 27 2018, 11:37 AM
labath accepted this revision.Jun 28 2018, 2:49 AM

Looks good. Thank you.

This revision is now accepted and ready to land.Jun 28 2018, 2:49 AM
This revision was automatically updated to reflect the committed changes.

This test fails on Windows with the Visual Studio generator.

##[error]llvm\tools\lldb\unittests\interpreter\testcompletion.cpp(291,0): Error : Value of: ContainsExactString(Twine("~/foo") + path::get_separator() + "nested" + path::get_separator(), Results)
e:\_work\1\s\llvm\tools\lldb\unittests\interpreter\testcompletion.cpp(291): error : Value of: ContainsExactString(Twine("~/foo") + path::get_separator() + "nested" + path::get_separator(), Results) [E:\_work\1\b\LLVMBuild\tools\lldb\lit\check-lldb-lit.vcxproj]
          
            Actual: false
          
          Expected: true
          
 ##[error]llvm\tools\lldb\unittests\interpreter\testcompletion.cpp(297,0): Error : Value of: ContainsExactString(Twine("~/foo") + path::get_separator() + "nested" + path::get_separator(), Results)
e:\_work\1\s\llvm\tools\lldb\unittests\interpreter\testcompletion.cpp(297): error : Value of: ContainsExactString(Twine("~/foo") + path::get_separator() + "nested" + path::get_separator(), Results) [E:\_work\1\b\LLVMBuild\tools\lldb\lit\check-lldb-lit.vcxproj]
          
            Actual: false
          
          Expected: true
          
          [  FAILED  ] CompletionTest.DirCompletionUsername (1 ms)
          
          [----------] 1 test from CompletionTest (1 ms total)