Index: lib/CodeGen/CGDecl.cpp =================================================================== --- lib/CodeGen/CGDecl.cpp +++ lib/CodeGen/CGDecl.cpp @@ -171,9 +171,15 @@ return ContextName.str() + "." + D.getNameAsString(); } -llvm::Constant * -CodeGenFunction::CreateStaticVarDecl(const VarDecl &D, - llvm::GlobalValue::LinkageTypes Linkage) { +llvm::Constant *CodeGenFunction::getOrCreateStaticVarDecl( + const VarDecl &D, llvm::GlobalValue::LinkageTypes Linkage) { + // In general, we don't always emit static var decls once before we reference + // them. It is possible to reference them before emitting the function that + // contains them, and it is possible to emit the containing function multiple + // times. + if (llvm::Constant *ExistingGV = CGM.getStaticLocalDeclAddress(&D)) + return ExistingGV; + QualType Ty = D.getType(); assert(Ty->isConstantSizeType() && "VLAs can't be static"); @@ -293,14 +299,7 @@ llvm::Value *&DMEntry = LocalDeclMap[&D]; assert(!DMEntry && "Decl already exists in localdeclmap!"); - // Check to see if we already have a global variable for this - // declaration. This can happen when double-emitting function - // bodies, e.g. with complete and base constructors. - llvm::Constant *addr = - CGM.getStaticLocalDeclAddress(&D); - - if (!addr) - addr = CreateStaticVarDecl(D, Linkage); + llvm::Constant *addr = getOrCreateStaticVarDecl(D, Linkage); // Store into LocalDeclMap before generating initializer to handle // circular references. Index: lib/CodeGen/CGExpr.cpp =================================================================== --- lib/CodeGen/CGExpr.cpp +++ lib/CodeGen/CGExpr.cpp @@ -1896,7 +1896,8 @@ llvm::Value *V = LocalDeclMap.lookup(VD); if (!V && VD->isStaticLocal()) - V = CGM.getStaticLocalDeclAddress(VD); + V = getOrCreateStaticVarDecl( + *VD, CGM.getLLVMLinkageVarDefinition(VD, /*isConstant=*/false)); // Use special handling for lambdas. if (!V) { Index: lib/CodeGen/CGExprConstant.cpp =================================================================== --- lib/CodeGen/CGExprConstant.cpp +++ lib/CodeGen/CGExprConstant.cpp @@ -868,8 +868,11 @@ if (!VD->hasLocalStorage()) { if (VD->isFileVarDecl() || VD->hasExternalStorage()) return CGM.GetAddrOfGlobalVar(VD); - else if (VD->isLocalVarDecl()) - return CGM.getStaticLocalDeclAddress(VD); + else if (VD->isLocalVarDecl()) { + assert(CGF && "cannot refer to static local outside function"); + return CGF->getOrCreateStaticVarDecl( + *VD, CGM.getLLVMLinkageVarDefinition(VD, /*isConstant=*/false)); + } } } return nullptr; Index: lib/CodeGen/CodeGenFunction.h =================================================================== --- lib/CodeGen/CodeGenFunction.h +++ lib/CodeGen/CodeGenFunction.h @@ -2424,8 +2424,9 @@ /// CreateStaticVarDecl - Create a zero-initialized LLVM global for /// a static local variable. - llvm::Constant *CreateStaticVarDecl(const VarDecl &D, - llvm::GlobalValue::LinkageTypes Linkage); + llvm::Constant * + getOrCreateStaticVarDecl(const VarDecl &D, + llvm::GlobalValue::LinkageTypes Linkage); /// AddInitializerToStaticVarDecl - Add the initializer for 'D' to the /// global variable that has already been created for it. If the initializer Index: test/CodeGenCXX/static-local-in-local-class.cpp =================================================================== --- test/CodeGenCXX/static-local-in-local-class.cpp +++ test/CodeGenCXX/static-local-in-local-class.cpp @@ -1,6 +1,12 @@ -// RUN: %clang_cc1 -emit-llvm -o %t %s -// PR6769 +// RUN: %clang_cc1 -triple x86_64-linux -emit-llvm -o - %s -std=c++1y | FileCheck %s + +// CHECK: @_ZZL14deduced_returnvE1n = internal global i32 0 +// CHECK: @"_ZZZNK17pr18020_constexpr3$_1clEvENKUlvE_clEvE2l2" = +// CHECK: internal global i32* @"_ZZNK17pr18020_constexpr3$_1clEvE2l1" + + +namespace pr6769 { struct X { static void f(); }; @@ -19,8 +25,9 @@ } (void)i; } +} -// pr7101 +namespace pr7101 { void foo() { static int n = 0; struct Helper { @@ -30,4 +37,77 @@ }; Helper::Execute(); } +} + +// These tests all break the assumption that the static var decl has to be +// emitted before use of the var decl. This happens because we defer emission +// of variables with internal linkage and no initialization side effects, such +// as 'x'. Then we hit operator()() in 'f', and emit the callee before we emit +// the arguments, so we emit the innermost function first. + +namespace pr18020_lambda { +// Referring to l1 before emitting it used to crash. +auto x = []() { + static int l1 = 0; + return [] { return l1; }; +}; +int f() { return x()(); } +} + +// CHECK-LABEL: define internal i32 @"_ZZNK14pr18020_lambda3$_0clEvENKUlvE_clEv" +// CHECK: load i32* @"_ZZNK14pr18020_lambda3$_0clEvE2l1" + +namespace pr18020_constexpr { +// Taking the address of l1 in a constant expression used to crash. +auto x = []() { + static int l1 = 0; + return [] { + static int *l2 = &l1; + return *l2; + }; +}; +int f() { return x()(); } +} + +// CHECK-LABEL: define internal i32 @"_ZZNK17pr18020_constexpr3$_1clEvENKUlvE_clEv" +// CHECK: load i32** @"_ZZZNK17pr18020_constexpr3$_1clEvENKUlvE_clEvE2l2" + +// Lambda-less reduction that references l1 before emitting it. This didn't +// crash if you put it in a namespace. +struct pr18020_class { + auto operator()() { + static int l1 = 0; + struct U { + int operator()() { return l1; } + }; + return U(); + } +}; +static pr18020_class x; +int pr18020_f() { return x()(); } + +// CHECK-LABEL: define linkonce_odr i32 @_ZZN13pr18020_classclEvEN1UclEv +// CHECK: load i32* @_ZZN13pr18020_classclEvE2l1 + +// In this test case, the function containing the static local will not be +// emitted because it is unneeded. However, the operator call of the inner class +// is called, and the static local is referenced and must be emitted. +static auto deduced_return() { + static int n; + struct S { int &operator()() { return n; } }; + return S(); +} + +extern "C" int call_deduced_return_operator() { + return decltype(deduced_return())()(); +} + +// CHECK-LABEL: define i32 @call_deduced_return_operator() +// CHECK: call dereferenceable(4) i32* @_ZZL14deduced_returnvEN1SclEv(%struct.S* %tmp) +// CHECK: load i32* % +// CHECK: ret i32 % + +// CHECK-LABEL: define internal dereferenceable(4) i32* @_ZZL14deduced_returnvEN1SclEv(%struct.S* %this) +// CHECK: ret i32* @_ZZL14deduced_returnvE1n +// FIXME: Surely we can exercise this edge case in C with -fblocks.