Index: cfe/trunk/lib/CodeGen/CGBuiltin.cpp =================================================================== --- cfe/trunk/lib/CodeGen/CGBuiltin.cpp +++ cfe/trunk/lib/CodeGen/CGBuiltin.cpp @@ -1252,8 +1252,9 @@ case Builtin::BI__builtin_labs: case Builtin::BI__builtin_llabs: { // X < 0 ? -X : X + // The negation has 'nsw' because abs of INT_MIN is undefined. Value *ArgValue = EmitScalarExpr(E->getArg(0)); - Value *NegOp = Builder.CreateNeg(ArgValue, "neg"); + Value *NegOp = Builder.CreateNSWNeg(ArgValue, "neg"); Constant *Zero = llvm::Constant::getNullValue(ArgValue->getType()); Value *CmpResult = Builder.CreateICmpSLT(ArgValue, Zero, "abscond"); Value *Result = Builder.CreateSelect(CmpResult, NegOp, ArgValue, "abs"); Index: cfe/trunk/test/CodeGen/builtin-abs.c =================================================================== --- cfe/trunk/test/CodeGen/builtin-abs.c +++ cfe/trunk/test/CodeGen/builtin-abs.c @@ -2,7 +2,7 @@ int absi(int x) { // CHECK-LABEL: @absi( -// CHECK: [[NEG:%.*]] = sub i32 0, [[X:%.*]] +// CHECK: [[NEG:%.*]] = sub nsw i32 0, [[X:%.*]] // CHECK: [[CMP:%.*]] = icmp slt i32 [[X]], 0 // CHECK: [[SEL:%.*]] = select i1 [[CMP]], i32 [[NEG]], i32 [[X]] // @@ -11,7 +11,7 @@ long absl(long x) { // CHECK-LABEL: @absl( -// CHECK: [[NEG:%.*]] = sub i64 0, [[X:%.*]] +// CHECK: [[NEG:%.*]] = sub nsw i64 0, [[X:%.*]] // CHECK: [[CMP:%.*]] = icmp slt i64 [[X]], 0 // CHECK: [[SEL:%.*]] = select i1 [[CMP]], i64 [[NEG]], i64 [[X]] // @@ -20,7 +20,7 @@ long long absll(long long x) { // CHECK-LABEL: @absll( -// CHECK: [[NEG:%.*]] = sub i64 0, [[X:%.*]] +// CHECK: [[NEG:%.*]] = sub nsw i64 0, [[X:%.*]] // CHECK: [[CMP:%.*]] = icmp slt i64 [[X]], 0 // CHECK: [[SEL:%.*]] = select i1 [[CMP]], i64 [[NEG]], i64 [[X]] //