Index: llvm/trunk/lib/Transforms/Scalar/NewGVN.cpp =================================================================== --- llvm/trunk/lib/Transforms/Scalar/NewGVN.cpp +++ llvm/trunk/lib/Transforms/Scalar/NewGVN.cpp @@ -1585,11 +1585,11 @@ SwappedOps ? Cmp->getSwappedPredicate() : Cmp->getPredicate(); if (isa(PI)) { - // If the comparison is true when the operands are equal, then we know the - // operands are equal, because assumes must always be true. - if (CmpInst::isTrueWhenEqual(Predicate)) { + // If we assume the operands are equal, then they are equal. + if (Predicate == CmpInst::ICMP_EQ) { addPredicateUsers(PI, I); - addAdditionalUsers(Cmp->getOperand(0), I); + addAdditionalUsers(SwappedOps ? Cmp->getOperand(1) : Cmp->getOperand(0), + I); return createVariableOrConstant(FirstOp); } } Index: llvm/trunk/test/Transforms/NewGVN/assumes.ll =================================================================== --- llvm/trunk/test/Transforms/NewGVN/assumes.ll +++ llvm/trunk/test/Transforms/NewGVN/assumes.ll @@ -0,0 +1,26 @@ +; RUN: opt < %s -newgvn -S | FileCheck %s + +; CHECK-LABEL: @test1 +; CHECK: ret i32 %arg +define i32 @test1(i32 %arg) { + %cmp = icmp sge i32 %arg, 5 + call void @llvm.assume(i1 %cmp) + ret i32 %arg +} + +; CHECK-LABEL: @test2 +; CHECK: ret i32 %arg +define i32 @test2(i32 %arg, i1 %b) { + br label %bb + +bb: + %a = phi i32 [ 1, %0 ], [ 2, %bb ] + %cmp = icmp eq i32 %arg, %a + call void @llvm.assume(i1 %cmp) + br i1 %b, label %bb, label %end + +end: + ret i32 %arg +} + +declare void @llvm.assume(i1 %cond)