Page MenuHomePhabricator

Emit ABI_PCS_R9_use build attribute.
ClosedPublic

Authored by bfoster on Jul 24 2014, 7:17 AM.

Details

Summary

Emit the build attribute describing how the r9 register is to be treated, (i.e. as V6 or not at all).

Diff Detail

Repository
rL LLVM

Event Timeline

bfoster updated this revision to Diff 11842.Jul 24 2014, 7:17 AM
bfoster retitled this revision from to Emit ABI_PCS_R9_use build attribute..
bfoster updated this object.
bfoster edited the test plan for this revision. (Show Details)
bfoster added a subscriber: Unknown Object (MLST).
bfoster updated this revision to Diff 11843.Jul 24 2014, 9:55 AM
bfoster added a reviewer: compnerd.

Thanks for looking at this Saleem;

I've updated the enum name and added the remaining two as you suggested, and dropped a todo for properly passing this from the frontend.

compnerd accepted this revision.Jul 24 2014, 10:11 AM
compnerd edited edge metadata.
compnerd added inline comments.
include/llvm/Support/ARMBuildAttributes.h
150 ↗(On Diff #11843)

Aligning the comments would be nice.

This revision is now accepted and ready to land.Jul 24 2014, 10:11 AM
bfoster updated this revision to Diff 11869.Jul 25 2014, 1:44 AM
bfoster edited edge metadata.

The comments are now aligned.

rengolin accepted this revision.Jul 25 2014, 4:09 AM
rengolin added a reviewer: rengolin.
rengolin added a subscriber: rengolin.

LGTM, thanks!

aemerson closed this revision.Jul 25 2014, 7:12 AM
aemerson updated this revision to Diff 11875.
aemerson added a subscriber: aemerson.

Closed by commit rL213944 (authored by @aemerson).