Index: lib/Transforms/Scalar/SROA.cpp =================================================================== --- lib/Transforms/Scalar/SROA.cpp +++ lib/Transforms/Scalar/SROA.cpp @@ -93,6 +93,7 @@ #include #include #include +#include #ifndef NDEBUG // We only use this for a debug check. @@ -1259,10 +1260,25 @@ } // Inject loads into all of the pred blocks. + std::unordered_map> Handled; for (unsigned Idx = 0, Num = PN.getNumIncomingValues(); Idx != Num; ++Idx) { BasicBlock *Pred = PN.getIncomingBlock(Idx); - TerminatorInst *TI = Pred->getTerminator(); Value *InVal = PN.getIncomingValue(Idx); + + // A PHI node is allowed to have multiple entries for the same basic block, + // as long as the value is the same. We make sure to avoid inserting + // multiple loads in such situations. + std::unordered_map >::const_iterator + HI = Handled.find(Pred); + if (HI != Handled.end()) { + assert(HI->second.first == InVal && + "PHI node has multiple entries for the same basic block with " + "different values"); + NewPN->addIncoming(HI->second.second, Pred); + continue; + } + + TerminatorInst *TI = Pred->getTerminator(); IRBuilderTy PredBuilder(TI); LoadInst *Load = PredBuilder.CreateLoad( @@ -1272,6 +1288,7 @@ if (AATags) Load->setAAMetadata(AATags); NewPN->addIncoming(Load, Pred); + Handled.insert({Pred, std::make_pair(InVal, Load)}); } DEBUG(dbgs() << " speculated to: " << *NewPN << "\n"); Index: test/Transforms/SROA/phi-with-duplicate-pred.ll =================================================================== --- /dev/null +++ test/Transforms/SROA/phi-with-duplicate-pred.ll @@ -0,0 +1,51 @@ +; NOTE: Assertions have been autogenerated by utils/update_test_checks.py +; RUN: opt < %s -sroa -S | FileCheck %s +target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:32:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-n8:16:32:64" + +@a = external global i16, align 1 + +define void @f2() { +; CHECK-LABEL: @f2( +; CHECK-NEXT: entry: +; CHECK-NEXT: br i1 undef, label [[IF_THEN:%.*]], label [[IF_ELSE:%.*]] +; CHECK: if.then: +; CHECK-NEXT: br label [[CLEANUP:%.*]] +; CHECK: cleanup: +; CHECK-NEXT: [[G_0_SROA_SPECULATE_LOAD_CLEANUP:%.*]] = load i16, i16* @a, align 1 +; CHECK-NEXT: switch i32 2, label [[CLEANUP7:%.*]] [ +; CHECK-NEXT: i32 0, label [[LBL1:%.*]] +; CHECK-NEXT: i32 2, label [[LBL1]] +; CHECK-NEXT: ] +; CHECK: if.else: +; CHECK-NEXT: br label [[LBL1]] +; CHECK: lbl1: +; CHECK-NEXT: [[G_0_SROA_SPECULATED:%.*]] = phi i16 [ [[G_0_SROA_SPECULATE_LOAD_CLEANUP]], [[CLEANUP]] ], [ [[G_0_SROA_SPECULATE_LOAD_CLEANUP]], [[CLEANUP]] ], [ undef, [[IF_ELSE]] ] +; CHECK-NEXT: unreachable +; CHECK: cleanup7: +; CHECK-NEXT: ret void +; +entry: + %e = alloca i16, align 1 + br i1 undef, label %if.then, label %if.else + +if.then: ; preds = %entry + br label %cleanup + +cleanup: ; preds = %if.then + switch i32 2, label %cleanup7 [ + i32 0, label %lbl1 + i32 2, label %lbl1 + ] + +if.else: ; preds = %entry + br label %lbl1 + +lbl1: ; preds = %if.else, %cleanup, %cleanup + %g.0 = phi i16* [ @a, %cleanup ], [ @a, %cleanup ], [ %e, %if.else ] + %0 = load i16, i16* %g.0, align 1 + unreachable + +cleanup7: ; preds = %cleanup + ret void +} +