Page MenuHomePhabricator

[compiler-rt: Builtins] Fix the incompatible assembly in ARM builtins library.
ClosedPublic

Authored by sgundapa on Jul 21 2014, 4:56 PM.

Details

Summary

This patch address the PR20360. It has the following fixes

  1. Make the assembly code in synh-ops.h to be UAL compliant
  2. Convert the CBNZ backward branch instruction to CMP and BNE

Diff Detail

Event Timeline

sgundapa updated this revision to Diff 11730.Jul 21 2014, 4:56 PM
sgundapa retitled this revision from to [compiler-rt: Builtins] Fix the incompatible assembly in ARM builtins library..
sgundapa updated this object.
sgundapa edited the test plan for this revision. (Show Details)
sgundapa added reviewers: t.p.northover, rengolin.
sgundapa set the repository for this revision to rL LLVM.
sgundapa added a subscriber: Unknown Object (MLST).
jroelofs accepted this revision.Jul 21 2014, 5:09 PM
jroelofs added a reviewer: jroelofs.
jroelofs added a subscriber: jroelofs.

LGTM, though I think you should check this in as two separate changes, first 1, then 2&3.

This revision is now accepted and ready to land.Jul 21 2014, 5:09 PM

Sure. I will split in to two

sgundapa updated this revision to Diff 11737.Jul 21 2014, 9:31 PM
sgundapa updated this object.
sgundapa edited edge metadata.
sgundapa set the repository for this revision to rL LLVM.

I split the earlier patch in to two

sgundapa requested a review of this revision.Jul 21 2014, 9:35 PM
sgundapa added a reviewer: compnerd.

The other half of the patch is at
http://reviews.llvm.org/D4614

rengolin accepted this revision.Jul 21 2014, 9:37 PM
rengolin edited edge metadata.
This revision is now accepted and ready to land.Jul 21 2014, 9:37 PM

I don't have commit access.
Can some one merge this ?

rengolin closed this revision.Jul 22 2014, 2:08 PM

r213685