Index: wasm/InputChunks.h =================================================================== --- wasm/InputChunks.h +++ wasm/InputChunks.h @@ -25,6 +25,7 @@ #include "InputFiles.h" #include "lld/Common/ErrorHandler.h" #include "llvm/Object/Wasm.h" +#include "llvm/Support/LEB128.h" using llvm::object::WasmSection; using llvm::object::WasmSegment; @@ -130,6 +131,7 @@ StringRef getName() const override { return Function->SymbolName; } StringRef getDebugName() const override { return Function->DebugName; } uint32_t getComdat() const override { return Function->Comdat; } + const ArrayRef getFunctionBody() const { return Function->Body; } uint32_t getFunctionIndex() const { return FunctionIndex.getValue(); } bool hasFunctionIndex() const { return FunctionIndex.hasValue(); } void setFunctionIndex(uint32_t Index); Index: wasm/InputChunks.cpp =================================================================== --- wasm/InputChunks.cpp +++ wasm/InputChunks.cpp @@ -89,6 +89,8 @@ break; case R_WEBASSEMBLY_TABLE_INDEX_I32: case R_WEBASSEMBLY_MEMORY_ADDR_I32: + case R_WEBASSEMBLY_FUNCTION_OFFSET_I32: + case R_WEBASSEMBLY_SECTION_OFFSET_I32: ExistingValue = static_cast(read32le(Loc)); write32le(Loc, Value); break; @@ -124,6 +126,8 @@ case R_WEBASSEMBLY_MEMORY_ADDR_LEB: case R_WEBASSEMBLY_MEMORY_ADDR_SLEB: case R_WEBASSEMBLY_MEMORY_ADDR_I32: + case R_WEBASSEMBLY_FUNCTION_OFFSET_I32: + case R_WEBASSEMBLY_SECTION_OFFSET_I32: writeSleb128(OS, Rel.Addend, "reloc addend"); break; } Index: wasm/InputFiles.h =================================================================== --- wasm/InputFiles.h +++ wasm/InputFiles.h @@ -14,6 +14,7 @@ #include "lld/Common/LLVM.h" #include "llvm/ADT/DenseMap.h" #include "llvm/ADT/DenseSet.h" +#include "llvm/ADT/StringMap.h" #include "llvm/Object/Archive.h" #include "llvm/Object/Wasm.h" #include "llvm/Support/MemoryBuffer.h" @@ -110,12 +111,14 @@ std::vector Functions; std::vector Globals; std::vector CustomSections; + llvm::DenseMap CustomSectionsByIndex; ArrayRef getSymbols() const { return Symbols; } Symbol *getSymbol(uint32_t Index) const { return Symbols[Index]; } FunctionSymbol *getFunctionSymbol(uint32_t Index) const; DataSymbol *getDataSymbol(uint32_t Index) const; GlobalSymbol *getGlobalSymbol(uint32_t Index) const; + SectionSymbol *getSectionSymbol(uint32_t Index) const; private: Symbol *createDefined(const WasmSymbol &Sym); Index: wasm/InputFiles.cpp =================================================================== --- wasm/InputFiles.cpp +++ wasm/InputFiles.cpp @@ -16,6 +16,7 @@ #include "lld/Common/Memory.h" #include "llvm/Object/Binary.h" #include "llvm/Object/Wasm.h" +#include "llvm/Support/LEB128.h" #include "llvm/Support/raw_ostream.h" #define DEBUG_TYPE "lld" @@ -42,6 +43,12 @@ return MBRef; } +static size_t getFunctionCodeOffset(const ArrayRef FunctionBody) { + unsigned Count; + llvm::decodeULEB128(FunctionBody.data(), &Count); + return Count; +} + void ObjFile::dumpInfo() const { log("info for: " + getName() + "\n Symbols : " + Twine(Symbols.size()) + @@ -80,6 +87,18 @@ return Segment.Data.Offset.Value.Int32 + Sym.Info.DataRef.Offset + Reloc.Addend; } + case R_WEBASSEMBLY_FUNCTION_OFFSET_I32: { + const WasmSymbol &Sym = WasmObj->syms()[Reloc.Index]; + if (Sym.isUndefined()) + return 0; + const WasmFunction &Function = + WasmObj->functions()[Sym.Info.ElementIndex - + WasmObj->getNumImportedFunctions()]; + size_t FunctionCodeOffset = getFunctionCodeOffset(Function.Body); + return Function.CodeSectionOffset + FunctionCodeOffset + Reloc.Addend; + } + case R_WEBASSEMBLY_SECTION_OFFSET_I32: + return Reloc.Addend; // TODO absolute to wasm file start? case R_WEBASSEMBLY_TYPE_INDEX_LEB: return Reloc.Index; case R_WEBASSEMBLY_FUNCTION_INDEX_LEB: @@ -110,6 +129,22 @@ return getFunctionSymbol(Reloc.Index)->getFunctionIndex(); case R_WEBASSEMBLY_GLOBAL_INDEX_LEB: return getGlobalSymbol(Reloc.Index)->getGlobalIndex(); + case R_WEBASSEMBLY_FUNCTION_OFFSET_I32: + if (auto *Sym = dyn_cast(getFunctionSymbol(Reloc.Index))) { + size_t FunctionCodeOffset = + getFunctionCodeOffset(Sym->Function->getFunctionBody()); + return Sym->Function->OutputOffset + FunctionCodeOffset + Reloc.Addend; + } + return 0; + case R_WEBASSEMBLY_SECTION_OFFSET_I32: + if (auto *Sym = dyn_cast(getSectionSymbol(Reloc.Index))) { + const SymbolTable::SyntheticSection &SyntheticSection = + Symtab->SyntheticSections[Sym->SectionIndex]; + const auto &InputSection = SyntheticSection.find(this); + if (InputSection != SyntheticSection.end()) + return InputSection->second->OutputOffset + Reloc.Addend; + } + return 0; default: llvm_unreachable("unknown relocation type"); } @@ -147,14 +182,19 @@ // Find the code and data sections. Wasm objects can have at most one code // and one data section. + uint32_t SectionIndex = 0; for (const SectionRef &Sec : WasmObj->sections()) { const WasmSection &Section = WasmObj->getWasmSection(Sec); - if (Section.Type == WASM_SEC_CODE) + if (Section.Type == WASM_SEC_CODE) { CodeSection = &Section; - else if (Section.Type == WASM_SEC_DATA) + } else if (Section.Type == WASM_SEC_DATA) { DataSection = &Section; - else if (Section.Type == WASM_SEC_CUSTOM) + } else if (Section.Type == WASM_SEC_CUSTOM) { CustomSections.emplace_back(make(Section, this)); + CustomSections.back()->copyRelocations(Section); + CustomSectionsByIndex[SectionIndex] = CustomSections.back(); + } + SectionIndex++; } TypeMap.resize(getWasmObj()->types().size()); @@ -215,6 +255,10 @@ return cast(Symbols[Index]); } +SectionSymbol *ObjFile::getSectionSymbol(uint32_t Index) const { + return cast(Symbols[Index]); +} + DataSymbol *ObjFile::getDataSymbol(uint32_t Index) const { return cast(Symbols[Index]); } @@ -253,14 +297,19 @@ return make(Name, Flags, this, Seg, Offset, Size); return Symtab->addDefinedData(Name, Flags, this, Seg, Offset, Size); } - case WASM_SYMBOL_TYPE_GLOBAL: + case WASM_SYMBOL_TYPE_GLOBAL: { InputGlobal *Global = Globals[Sym.Info.ElementIndex - WasmObj->getNumImportedGlobals()]; if (Sym.isBindingLocal()) return make(Name, Flags, this, Global); return Symtab->addDefinedGlobal(Name, Flags, this, Global); } - llvm_unreachable("unkown symbol kind"); + case WASM_SYMBOL_TYPE_SECTION: { + InputSection *Section = CustomSectionsByIndex[Sym.Info.ElementIndex]; + return Symtab->addDefinedSection(Name, Flags, this, Section); + } + } + llvm_unreachable("unknown symbol kind"); } Symbol *ObjFile::createUndefined(const WasmSymbol &Sym) { @@ -274,8 +323,10 @@ return Symtab->addUndefinedData(Name, Flags, this); case WASM_SYMBOL_TYPE_GLOBAL: return Symtab->addUndefinedGlobal(Name, Flags, this, Sym.GlobalType); + case WASM_SYMBOL_TYPE_SECTION: + return Symtab->addUndefinedSection(Name, Flags, this); } - llvm_unreachable("unkown symbol kind"); + llvm_unreachable("unknown symbol kind"); } void ArchiveFile::parse() { Index: wasm/OutputSections.h =================================================================== --- wasm/OutputSections.h +++ wasm/OutputSections.h @@ -127,6 +127,8 @@ return Header.size() + NameData.size() + PayloadSize; } void writeTo(uint8_t *Buf) override; + uint32_t numRelocations() const override; + void writeRelocations(raw_ostream &OS) const override; protected: size_t PayloadSize; Index: wasm/OutputSections.cpp =================================================================== --- wasm/OutputSections.cpp +++ wasm/OutputSections.cpp @@ -224,3 +224,15 @@ parallelForEach(InputSections, [&](const InputSection *Section) { Section->writeTo(Buf); }); } + +uint32_t CustomSection::numRelocations() const { + uint32_t Count = 0; + for (const InputSection *InputSect : InputSections) + Count += InputSect->NumRelocations(); + return Count; +} + +void CustomSection::writeRelocations(raw_ostream &OS) const { + for (const InputSection *S : InputSections) + S->writeRelocations(OS); +} Index: wasm/SymbolTable.h =================================================================== --- wasm/SymbolTable.h +++ wasm/SymbolTable.h @@ -13,6 +13,7 @@ #include "InputFiles.h" #include "Symbols.h" #include "llvm/ADT/CachedHashString.h" +#include "llvm/ADT/DenseMap.h" #include "llvm/ADT/DenseSet.h" #include "llvm/Support/raw_ostream.h" @@ -38,11 +39,14 @@ // There is one add* function per symbol type. class SymbolTable { public: + using SyntheticSection = llvm::DenseMap; + void addFile(InputFile *File); std::vector ObjectFiles; std::vector SyntheticFunctions; std::vector SyntheticGlobals; + std::vector SyntheticSections; void reportRemainingUndefines(); @@ -56,12 +60,15 @@ uint32_t Size); Symbol *addDefinedGlobal(StringRef Name, uint32_t Flags, InputFile *File, InputGlobal *G); + Symbol *addDefinedSection(StringRef Name, uint32_t Flags, InputFile *File, + InputSection *S); Symbol *addUndefinedFunction(StringRef Name, uint32_t Flags, InputFile *File, const WasmSignature *Signature); Symbol *addUndefinedData(StringRef Name, uint32_t Flags, InputFile *File); Symbol *addUndefinedGlobal(StringRef Name, uint32_t Flags, InputFile *File, const WasmGlobalType *Type); + Symbol *addUndefinedSection(StringRef Name, uint32_t Flags, InputFile *File); void addLazy(ArchiveFile *F, const Archive::Symbol *Sym); Index: wasm/SymbolTable.cpp =================================================================== --- wasm/SymbolTable.cpp +++ wasm/SymbolTable.cpp @@ -231,6 +231,27 @@ return S; } +Symbol *SymbolTable::addDefinedSection(StringRef Name, uint32_t Flags, + InputFile *File, InputSection *Section) { + DEBUG(dbgs() << "addDefinedSection:" << Name << "\n"); + Symbol *S; + bool WasInserted; + std::tie(S, WasInserted) = insert(Name); + + if (WasInserted || S->isLazy() || isa(S)) { + replaceSymbol(S, Name, Flags, SyntheticSections.size()); + SyntheticSections.emplace_back(); + SyntheticSections.back()[File] = Section; + return S; + } + + assert(isa(S)); + auto &SectionItems = + SyntheticSections[dyn_cast(S)->SectionIndex]; + SectionItems[File] = Section; + return S; +} + Symbol *SymbolTable::addUndefinedFunction(StringRef Name, uint32_t Flags, InputFile *File, const WasmSignature *Sig) { @@ -284,6 +305,20 @@ return S; } +Symbol *SymbolTable::addUndefinedSection(StringRef Name, uint32_t Flags, + InputFile *File) { + DEBUG(dbgs() << "addUndefinedSection:" << Name << "\n"); + + Symbol *S; + bool WasInserted; + std::tie(S, WasInserted) = insert(Name); + + if (WasInserted) + replaceSymbol(S, Name, Flags); + assert(isa(S)); + return S; +} + void SymbolTable::addLazy(ArchiveFile *File, const Archive::Symbol *Sym) { DEBUG(dbgs() << "addLazy: " << Sym->getName() << "\n"); StringRef Name = Sym->getName(); Index: wasm/Symbols.h =================================================================== --- wasm/Symbols.h +++ wasm/Symbols.h @@ -30,6 +30,7 @@ class InputSegment; class InputFunction; class InputGlobal; +class InputSection; #define INVALID_INDEX UINT32_MAX @@ -40,9 +41,11 @@ DefinedFunctionKind, DefinedDataKind, DefinedGlobalKind, + DefinedSectionKind, UndefinedFunctionKind, UndefinedDataKind, UndefinedGlobalKind, + UndefinedSectionKind, LazyKind, }; @@ -50,12 +53,14 @@ bool isDefined() const { return SymbolKind == DefinedFunctionKind || SymbolKind == DefinedDataKind || - SymbolKind == DefinedGlobalKind; + SymbolKind == DefinedGlobalKind || SymbolKind == DefinedSectionKind; } bool isUndefined() const { return SymbolKind == UndefinedFunctionKind || - SymbolKind == UndefinedDataKind || SymbolKind == UndefinedGlobalKind; + SymbolKind == UndefinedDataKind || + SymbolKind == UndefinedGlobalKind || + SymbolKind == UndefinedSectionKind; } bool isLazy() const { return SymbolKind == LazyKind; } @@ -155,6 +160,44 @@ } }; +class SectionSymbol : public Symbol { +public: + static bool classof(const Symbol *S) { + return S->kind() == DefinedSectionKind || S->kind() == UndefinedSectionKind; + } + + SectionSymbol(StringRef Name, Kind K, uint32_t Flags, InputFile *F = nullptr) + : Symbol(Name, K, Flags, F) {} + + uint32_t getOutputSymbolIndex() const; + void setOutputSymbolIndex(uint32_t Index); + +protected: + uint32_t OutputSymbolIndex = INVALID_INDEX; +}; + +class DefinedSection : public SectionSymbol { +public: + DefinedSection(StringRef Name, uint32_t Flags, size_t Index) + : SectionSymbol(Name, DefinedSectionKind, Flags), SectionIndex(Index) {} + + static bool classof(const Symbol *S) { + return S->kind() == DefinedSectionKind; + } + + size_t SectionIndex; +}; + +class UndefinedSection : public SectionSymbol { +public: + UndefinedSection(StringRef Name, uint32_t Flags) + : SectionSymbol(Name, UndefinedSectionKind, Flags) {} + + static bool classof(const Symbol *S) { + return S->kind() == UndefinedSectionKind; + } +}; + class DataSymbol : public Symbol { public: static bool classof(const Symbol *S) { @@ -297,10 +340,12 @@ alignas(DefinedFunction) char A[sizeof(DefinedFunction)]; alignas(DefinedData) char B[sizeof(DefinedData)]; alignas(DefinedGlobal) char C[sizeof(DefinedGlobal)]; + alignas(DefinedSection) char I[sizeof(DefinedSection)]; alignas(LazySymbol) char D[sizeof(LazySymbol)]; alignas(UndefinedFunction) char E[sizeof(UndefinedFunction)]; alignas(UndefinedData) char F[sizeof(UndefinedData)]; alignas(UndefinedGlobal) char G[sizeof(UndefinedGlobal)]; + alignas(UndefinedSection) char J[sizeof(UndefinedSection)]; }; template Index: wasm/Symbols.cpp =================================================================== --- wasm/Symbols.cpp +++ wasm/Symbols.cpp @@ -36,6 +36,8 @@ return llvm::wasm::WASM_SYMBOL_TYPE_DATA; if (isa(this)) return llvm::wasm::WASM_SYMBOL_TYPE_GLOBAL; + if (isa(this)) + return llvm::wasm::WASM_SYMBOL_TYPE_SECTION; llvm_unreachable("invalid symbol kind"); } @@ -194,6 +196,19 @@ Global ? &Global->getType() : nullptr), Global(Global) {} +uint32_t SectionSymbol::getOutputSymbolIndex() const { + DEBUG(dbgs() << "getOutputSymbolIndex: " << getName() << "\n"); + assert(OutputSymbolIndex != INVALID_INDEX); + return OutputSymbolIndex; +} + +void SectionSymbol::setOutputSymbolIndex(uint32_t Index) { + DEBUG(dbgs() << "setOutputSymbolIndex: " << getName() << " -> " << Index + << "\n"); + assert(Index != INVALID_INDEX); + OutputSymbolIndex = Index; +} + void LazySymbol::fetch() { cast(File)->addMember(&ArchiveSymbol); } std::string lld::toString(const wasm::Symbol &Sym) { @@ -211,12 +226,16 @@ return "DefinedData"; case wasm::Symbol::DefinedGlobalKind: return "DefinedGlobal"; + case wasm::Symbol::DefinedSectionKind: + return "DefinedSection"; case wasm::Symbol::UndefinedFunctionKind: return "UndefinedFunction"; case wasm::Symbol::UndefinedDataKind: return "UndefinedData"; case wasm::Symbol::UndefinedGlobalKind: return "UndefinedGlobal"; + case wasm::Symbol::UndefinedSectionKind: + return "UndefinedSection"; case wasm::Symbol::LazyKind: return "LazyKind"; } @@ -231,6 +250,8 @@ return "Data"; case llvm::wasm::WASM_SYMBOL_TYPE_GLOBAL: return "Global"; + case llvm::wasm::WASM_SYMBOL_TYPE_SECTION: + return "Section"; } llvm_unreachable("invalid symbol type"); } Index: wasm/Writer.cpp =================================================================== --- wasm/Writer.cpp +++ wasm/Writer.cpp @@ -67,6 +67,7 @@ void assignIndexes(); void calculateImports(); void calculateExports(); + void calculateCustomSections(); void assignSymtab(); void calculateTypes(); void createOutputSegments(); @@ -123,6 +124,7 @@ std::vector Segments; llvm::SmallDenseMap SegmentMap; + llvm::StringSet<> InternedNames; }; } // anonymous namespace @@ -299,18 +301,28 @@ } } -void Writer::createCustomSections() { +void Writer::calculateCustomSections() { log("createCustomSections"); - for (ObjFile *File : Symtab->ObjectFiles) - for (InputSection *Section : File->CustomSections) - CustomSectionMapping[Section->getName()].push_back(Section); + bool StripDebug = Config->StripDebug || Config->StripAll; + for (ObjFile *File : Symtab->ObjectFiles) { + for (InputSection *Section : File->CustomSections) { + StringRef Name = Section->getName(); + // These custom sections are known the linker and synthesized rather than + // blindly copied + if (Name == "linking" || Name == "name" || Name.startswith("reloc.")) + continue; + // .. or it is a debug section + if (StripDebug && Name.startswith(".debug_")) + continue; + CustomSectionMapping[Name].push_back(Section); + } + } +} +void Writer::createCustomSections() { + log("createCustomSections"); for (auto &Pair : CustomSectionMapping) { StringRef Name = Pair.first(); - // These custom sections are known the linker and synthesized rather than - // blindly copied - if (Name == "linking" || Name == "name" || Name.startswith("reloc.")) - continue; DEBUG(dbgs() << "createCustomSection: " << Name << "\n"); OutputSections.push_back(make(Name, Pair.second)); } @@ -375,6 +387,9 @@ Name = "reloc.DATA"; else if (OSec->Type == WASM_SEC_CODE) Name = "reloc.CODE"; + else if (OSec->Type == WASM_SEC_CUSTOM && + StringRef(OSec->Name).startswith(".debug")) + Name = InternedNames.insert("reloc." + OSec->Name).first->getKey(); else llvm_unreachable("relocations only supported for code and data"); @@ -423,6 +438,12 @@ raw_string_ostream OS{Body}; }; +static StringRef getSectionNameFromSymbol(const DefinedSection *Sym) { + const auto &SyntheticSection = Symtab->SyntheticSections[Sym->SectionIndex]; + const auto &InputSection = SyntheticSection.begin()->second; + return InputSection->getName(); +} + // Create the custom "linking" section containing linker metadata. // This is only created when relocatable output is requested. void Writer::createLinkingSection() { @@ -453,8 +474,7 @@ writeUleb128(Sub.OS, G->getGlobalIndex(), "index"); if (Sym->isDefined()) writeStr(Sub.OS, Sym->getName(), "sym name"); - } else { - assert(isa(Sym)); + } else if (auto *D = dyn_cast(Sym)) { writeStr(Sub.OS, Sym->getName(), "sym name"); if (auto *DataSym = dyn_cast(Sym)) { writeUleb128(Sub.OS, DataSym->getOutputSegmentIndex(), "index"); @@ -462,7 +482,12 @@ "data offset"); writeUleb128(Sub.OS, DataSym->getSize(), "data size"); } - } + } else if (auto *S = dyn_cast(Sym)) { + StringRef SectionName = getSectionNameFromSymbol(S); + writeUleb128(Sub.OS, WASM_SEC_CUSTOM, "sym section type"); + writeStr(Sub.OS, SectionName, "sym section name"); + } else + assert(false); } Sub.writeTo(OS); @@ -720,6 +745,8 @@ continue; if (!Sym->isLive()) continue; + if (isa(Sym)) + continue; DEBUG(dbgs() << "exporting sym: " << Sym->getName() << "\n"); @@ -737,6 +764,16 @@ for (ObjFile *File : Symtab->ObjectFiles) { DEBUG(dbgs() << "Symtab entries: " << File->getName() << "\n"); for (Symbol *Sym : File->getSymbols()) { + if (auto *S = dyn_cast(Sym)) { + StringRef SectionName = getSectionNameFromSymbol(S); + if (CustomSectionMapping.find(SectionName) != + CustomSectionMapping.end()) { + Sym->setOutputSymbolIndex(SymbolIndex++); + SymtabEntries.emplace_back(Sym); + } + continue; + } + if (Sym->getFile() != File) continue; // (Since this is relocatable output, GC is not performed so symbols must @@ -837,6 +874,8 @@ HandleRelocs(Chunk); for (InputChunk *Chunk : File->Segments) HandleRelocs(Chunk); + for (auto &P : File->CustomSections) + HandleRelocs(P); } uint32_t GlobalIndex = NumImportedGlobals + InputGlobals.size(); @@ -958,6 +997,8 @@ layoutMemory(); log("-- calculateExports"); calculateExports(); + log("-- calculateCustomSections"); + calculateCustomSections(); log("-- assignSymtab"); assignSymtab();