Index: clang/lib/CodeGen/CodeGenFunction.cpp =================================================================== --- clang/lib/CodeGen/CodeGenFunction.cpp +++ clang/lib/CodeGen/CodeGenFunction.cpp @@ -846,8 +846,14 @@ if (D) { // Apply the no_sanitize* attributes to SanOpts. - for (auto Attr : D->specific_attrs()) - SanOpts.Mask &= ~Attr->getMask(); + for (auto Attr : D->specific_attrs()) { + SanitizerMask mask = Attr->getMask(); + SanOpts.Mask &= ~mask; + if (mask & SanitizerKind::Address) + SanOpts.set(SanitizerKind::KernelAddress, false); + if (mask & SanitizerKind::KernelAddress) + SanOpts.set(SanitizerKind::Address, false); + } } // Apply sanitizer attributes to the function. Index: clang/test/CodeGen/address-safety-attr-flavors.cpp =================================================================== --- clang/test/CodeGen/address-safety-attr-flavors.cpp +++ clang/test/CodeGen/address-safety-attr-flavors.cpp @@ -1,5 +1,5 @@ -// Make sure the sanitize_address attribute is emitted when using both ASan and KASan. -// Also document that __attribute__((no_sanitize_address)) doesn't disable KASan instrumentation. +// Make sure the sanitize_address attribute is emitted when using ASan, KASan or HWASan. +// Either __attribute__((no_sanitize("address")) or __attribute__((no_sanitize("kernel-address")) disables both ASan and KASan instrumentation. /// RUN: %clang_cc1 -triple i386-unknown-linux -disable-O0-optnone -emit-llvm -o - %s | FileCheck -check-prefix=CHECK-NOASAN %s /// RUN: %clang_cc1 -triple i386-unknown-linux -fsanitize=address -disable-O0-optnone -emit-llvm -o - %s | FileCheck -check-prefix=CHECK-ASAN %s @@ -20,7 +20,7 @@ } // CHECK-NOASAN: {{Function Attrs: noinline nounwind$}} // CHECK-ASAN: {{Function Attrs: noinline nounwind$}} -// CHECK-KASAN: {{Function Attrs: noinline nounwind sanitize_address$}} +// CHECK-KASAN: {{Function Attrs: noinline nounwind$}} // CHECK-HWASAN: {{Function Attrs: noinline nounwind sanitize_hwaddress$}} __attribute__((no_sanitize_address)) @@ -29,16 +29,15 @@ } // CHECK-NOASAN: {{Function Attrs: noinline nounwind$}} // CHECK-ASAN: {{Function Attrs: noinline nounwind$}} -// CHECK-KASAN: {{Function Attrs: noinline nounwind sanitize_address$}} +// CHECK-KASAN: {{Function Attrs: noinline nounwind$}} // CHECK-HWASAN: {{Function Attrs: noinline nounwind sanitize_hwaddress$}} __attribute__((no_sanitize("kernel-address"))) int NoSanitizeKernelAddress() { return 0; } - // CHECK-NOASAN: {{Function Attrs: noinline nounwind$}} -// CHECK-ASAN: {{Function Attrs: noinline nounwind sanitize_address$}} +// CHECK-ASAN: {{Function Attrs: noinline nounwind$}} // CHECK-KASAN: {{Function Attrs: noinline nounwind$}} // CHECK-HWASAN: {{Function Attrs: noinline nounwind sanitize_hwaddress$}} @@ -46,7 +45,6 @@ int NoSanitizeHWAddress() { return 0; } - // CHECK-NOASAN: {{Function Attrs: noinline nounwind$}} // CHECK-ASAN: {{Function Attrs: noinline nounwind sanitize_address$}} // CHECK-KASAN: {{Function Attrs: noinline nounwind sanitize_address$}} Index: clang/test/CodeGen/address-safety-attr-kasan.cpp =================================================================== --- clang/test/CodeGen/address-safety-attr-kasan.cpp +++ /dev/null @@ -1,38 +0,0 @@ -// Make sure the sanitize_address attribute is emitted when using both ASan and KASan. -// Also document that __attribute__((no_sanitize_address)) doesn't disable KASan instrumentation. - -/// RUN: %clang_cc1 -triple i386-unknown-linux -disable-O0-optnone -emit-llvm -o - %s | FileCheck -check-prefix=CHECK-NOASAN %s -/// RUN: %clang_cc1 -triple i386-unknown-linux -fsanitize=address -disable-O0-optnone -emit-llvm -o - %s | FileCheck -check-prefix=CHECK-ASAN %s -/// RUN: %clang_cc1 -triple i386-unknown-linux -fsanitize=kernel-address -disable-O0-optnone -emit-llvm -o - %s | FileCheck -check-prefix=CHECK-KASAN %s - -int HasSanitizeAddress() { - return 1; -} -// CHECK-NOASAN: {{Function Attrs: noinline nounwind$}} -// CHECK-ASAN: Function Attrs: noinline nounwind sanitize_address -// CHECK-KASAN: Function Attrs: noinline nounwind sanitize_address - -__attribute__((no_sanitize("address"))) -int NoSanitizeQuoteAddress() { - return 0; -} -// CHECK-NOASAN: {{Function Attrs: noinline nounwind$}} -// CHECK-ASAN: {{Function Attrs: noinline nounwind$}} -// CHECK-KASAN: {{Function Attrs: noinline nounwind sanitize_address$}} - -__attribute__((no_sanitize_address)) -int NoSanitizeAddress() { - return 0; -} -// CHECK-NOASAN: {{Function Attrs: noinline nounwind$}} -// CHECK-ASAN: {{Function Attrs: noinline nounwind$}} -// CHECK-KASAN: {{Function Attrs: noinline nounwind sanitize_address$}} - -__attribute__((no_sanitize("kernel-address"))) -int NoSanitizeKernelAddress() { - return 0; -} - -// CHECK-NOASAN: {{Function Attrs: noinline nounwind$}} -// CHECK-ASAN: {{Function Attrs: noinline nounwind sanitize_address$}} -// CHECK-KASAN: {{Function Attrs: noinline nounwind$}}