Index: clang/include/clang/Sema/Sema.h =================================================================== --- clang/include/clang/Sema/Sema.h +++ clang/include/clang/Sema/Sema.h @@ -7550,6 +7550,10 @@ /// but have not yet been performed. std::deque PendingInstantiations; + /// Queue of implicit template instantiations that cannot be performed + /// eagerly. + SmallVector LateParsedInstantiations; + class GlobalEagerInstantiationScope { public: GlobalEagerInstantiationScope(Sema &S, bool Enabled) Index: clang/lib/Sema/Sema.cpp =================================================================== --- clang/lib/Sema/Sema.cpp +++ clang/lib/Sema/Sema.cpp @@ -879,8 +879,20 @@ PendingInstantiations.insert(PendingInstantiations.begin(), Pending.begin(), Pending.end()); } + + // Now that we are at the end of the TU and we have the late template + // parser, transfer late parsed instantiations onto PendingInstantiations. + PendingInstantiations.insert(PendingInstantiations.end(), + LateParsedInstantiations.begin(), + LateParsedInstantiations.end()); + LateParsedInstantiations.clear(); + PerformPendingInstantiations(); + assert(LateParsedInstantiations.empty() && + "end of TU template instantiation should not create more " + "late-parsed templates"); + if (LateTemplateParserCleanup) LateTemplateParserCleanup(OpaqueParser); Index: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp =================================================================== --- clang/lib/Sema/SemaTemplateInstantiateDecl.cpp +++ clang/lib/Sema/SemaTemplateInstantiateDecl.cpp @@ -3837,8 +3837,8 @@ if (PatternDecl->isLateTemplateParsed() && !LateTemplateParser) { Function->setInstantiationIsPending(true); - PendingInstantiations.push_back( - std::make_pair(Function, PointOfInstantiation)); + LateParsedInstantiations.push_back( + std::make_pair(Function, PointOfInstantiation)); return; } Index: clang/test/SemaTemplate/late-parsing-eager-instantiation.cpp =================================================================== --- /dev/null +++ clang/test/SemaTemplate/late-parsing-eager-instantiation.cpp @@ -0,0 +1,40 @@ +// RUN: %clang_cc1 -std=c++14 -verify %s + +// pr33561 +class ArrayBuffer; +template class Trans_NS_WTF_RefPtr { +public: + ArrayBuffer *operator->() { return nullptr; } +}; +Trans_NS_WTF_RefPtr get(); +template +constexpr void visit(_Visitor __visitor) { + __visitor(get()); // expected-note {{in instantiation}} +} +class ArrayBuffer { + char data() { + visit([](auto buffer) -> char { // expected-note {{in instantiation}} + buffer->data(); + }); // expected-warning {{control reaches end of non-void lambda}} + } // expected-warning {{control reaches end of non-void function}} +}; + +// pr34185 +template struct coroutine_handle { + Promise &promise() const { return + *static_cast(nullptr); // expected-warning {{binding dereferenced null}} + } +}; + +template auto GetCurrenPromise() { + struct Awaiter { // expected-note {{in instantiation}} + void await_suspend(coroutine_handle h) { + h.promise(); // expected-note {{in instantiation}} + } + }; + return Awaiter{}; +} + +void foo() { + auto &&p = GetCurrenPromise(); // expected-note {{in instantiation}} +}