Page MenuHomePhabricator

[dotest] Use subprocess.call to forward arguments in wrapper
ClosedPublic

Authored by JDevlieghere on Mar 21 2018, 3:20 AM.

Details

Summary

As suggested by Pavel on lldb-commits. Originally I picked os.system because it was so much more simple than the subprocess module, but that no longer holds true after yesterday's hack in r328020. This is what it should've been in the first place.

Event Timeline

JDevlieghere created this revision.Mar 21 2018, 3:20 AM

Re-add accidentally removed comment.

labath accepted this revision.Mar 21 2018, 3:33 AM

Thank you. This looks good, assuming that the LLDB_DOTEST_ARGS_STR thingy is working as intended.

test/lldb-dotest.in
6 ↗(On Diff #139270)

I'm confused. Shouldn't this be @LLDB_DOTEST_ARGS@, now that you've removed the _STR version?

This revision is now accepted and ready to land.Mar 21 2018, 3:33 AM
JDevlieghere marked an inline comment as done.Mar 21 2018, 3:41 AM

Thank you. This looks good, assuming that the LLDB_DOTEST_ARGS_STR thingy is working as intended.

Good catch, the variable was still available from the cache. I'll commit this with the fix.

This revision was automatically updated to reflect the committed changes.