Index: lld/COFF/LTO.cpp =================================================================== --- lld/COFF/LTO.cpp +++ lld/COFF/LTO.cpp @@ -64,6 +64,12 @@ static std::unique_ptr createLTO() { lto::Config Conf; Conf.Options = InitTargetOptionsFromCodeGenFlags(); + + // Always emit a section per function/datum with LTO. LLVM LTO should get most + // of the benefit of linker GC, but there are still opportunities for ICF. + Conf.Options.FunctionSections = true; + Conf.Options.DataSections = true; + // Use static reloc model on 32-bit x86 because it usually results in more // compact code, and because there are also known code generation bugs when // using the PIC model (see PR34306). Index: lld/test/COFF/lto-icf.ll =================================================================== --- /dev/null +++ lld/test/COFF/lto-icf.ll @@ -0,0 +1,26 @@ +; Test that ICF works after LTO, i.e. both functions have the same address. +; Previously, when we didn't enable function sections, ICF didn't work. + +; RUN: llvm-as %s -o %t.bc +; RUN: lld-link -opt:icf -dll -noentry %t.bc -out:%t.dll +; RUN: llvm-readobj -coff-exports %t.dll | FileCheck %s + +; CHECK: Export { +; CHECK: Export { +; CHECK: RVA: 0x[[RVA:.*]] +; CHECK: Export { +; CHECK: RVA: 0x[[RVA]] +; CHECK-NOT: Export + +target datalayout = "e-m:w-i64:64-f80:128-n8:16:32:64-S128" +target triple = "x86_64-pc-windows-msvc19.12.25835" + +define dllexport i8* @icf_ptr() { +entry: + ret i8* null +} + +define dllexport i64 @icf_int() { +entry: + ret i64 0 +}