This is an archive of the discontinued LLVM Phabricator instance.

[lldb] Unbreak lldb builds due to r327219
ClosedPublic

Authored by mgrang on Mar 10 2018, 12:35 PM.

Details

Summary

r327219 adds wrappers to sort which shuffle the container before sorting.
This causes lldb bots to break as the call to sort is now ambiguous:
http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-buildserver/builds/20725/steps/ninja%20build%20local/logs/stdio

So we need use llvm::sort instead of sort to avoid ambiguity with std::sort.

Note: This patch is just to unbreak the bots. I plan to have subsequent patches which will convert all
calls to std::sort to llvm::sort.

Diff Detail

Repository
rL LLVM

Event Timeline

mgrang created this revision.Mar 10 2018, 12:35 PM
Eugene.Zelenko set the repository for this revision to rL LLVM.
Eugene.Zelenko added a project: Restricted Project.
Eugene.Zelenko edited subscribers, added: lldb-commits; removed: llvm-commits.

If this patch is to unbreak the buildbots, then I think you should just commit it.
We don't want to leave the buildbots in a failing state for too long.

If instead you don't feel confortable about this fix, then you should revert r327219.

This revision was not accepted when it landed; it landed in state Needs Review.Mar 10 2018, 1:18 PM
This revision was automatically updated to reflect the committed changes.

(post) LGTM