This is an archive of the discontinued LLVM Phabricator instance.

[ms-coff] Add a test for proper handling of full Windows path names in the .drectve section
ClosedPublic

Authored by • ehsan on Jul 8 2014, 4:50 PM.

Reviewers

• rafael
rnk

Commits

Summary

This test ensures that we can correctly specify a full Windows path to the clang ASAN runtime libraries. This is in preparation to fix PR20246.

• ehsan retitled this revision from to [ms-coff] Add a test for proper handling of full Windows path names in the .drectve section.

• ehsan updated this object.

• ehsan edited the test plan for this revision. (Show Details)

• ehsan added a reviewer: • rafael.

• ehsan added a subscriber: Unknown Object (MLST).

lgtm

Tests are good. :)

This revision is now accepted and ready to land.Jul 8 2014, 5:39 PM

Closed by commit rL212580 (authored by @ehsan).

Path

Size

llvm/

trunk/

test/

MC/

COFF/

2 lines

	; RUN: llc -O0 -mtriple=i386-pc-win32 -filetype=asm -o - %s \| FileCheck %s			; RUN: llc -O0 -mtriple=i386-pc-win32 -filetype=asm -o - %s \| FileCheck %s

	!0 = metadata !{ i32 6, metadata !"Linker Options",			!0 = metadata !{ i32 6, metadata !"Linker Options",
	metadata !{			metadata !{
	metadata !{ metadata !"/DEFAULTLIB:msvcrt.lib" },			metadata !{ metadata !"/DEFAULTLIB:msvcrt.lib" },
	metadata !{ metadata !"/DEFAULTLIB:msvcrt.lib",			metadata !{ metadata !"/DEFAULTLIB:msvcrt.lib",
	metadata !"/DEFAULTLIB:secur32.lib" },			metadata !"/DEFAULTLIB:secur32.lib" },
				metadata !{ metadata !"/DEFAULTLIB:C:\5Cpath to\5Casan_rt.lib" },
	metadata !{ metadata !"/with spaces" } } }			metadata !{ metadata !"/with spaces" } } }

	!llvm.module.flags = !{ !0 }			!llvm.module.flags = !{ !0 }

	define dllexport void @foo() {			define dllexport void @foo() {
	ret void			ret void
	}			}

	; CHECK: .section .drectve,"r"			; CHECK: .section .drectve,"r"
	; CHECK: .ascii " /DEFAULTLIB:msvcrt.lib"			; CHECK: .ascii " /DEFAULTLIB:msvcrt.lib"
	; CHECK: .ascii " /DEFAULTLIB:msvcrt.lib"			; CHECK: .ascii " /DEFAULTLIB:msvcrt.lib"
	; CHECK: .ascii " /DEFAULTLIB:secur32.lib"			; CHECK: .ascii " /DEFAULTLIB:secur32.lib"
				; CHECK: .ascii " \"/DEFAULTLIB:C:\\path to\\asan_rt.lib\""
	; CHECK: .ascii " \"/with spaces\""			; CHECK: .ascii " \"/with spaces\""
	; CHECK: .ascii " /EXPORT:_foo"			; CHECK: .ascii " /EXPORT:_foo"