Page MenuHomePhabricator

Add FreeBSD support to the address sanitizer's waitid.cc test case
ClosedPublic

Authored by kutuzov.viktor.84 on Jul 8 2014, 5:57 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

kutuzov.viktor.84 retitled this revision from to Add FreeBSD support to the address sanitizer's waitid.cc test case.
kutuzov.viktor.84 updated this object.
kutuzov.viktor.84 edited the test plan for this revision. (Show Details)
kutuzov.viktor.84 added reviewers: kcc, samsonov.
kutuzov.viktor.84 added subscribers: Unknown Object (MLST), theraven, emaste.
kcc edited edge metadata.Jul 8 2014, 6:17 AM

can/should we include signal.h unconditionally?

kutuzov.viktor.84 edited edge metadata.

Right, <signal.h> should be available on both Linux, Darwin and FreeBSD.

samsonov accepted this revision.Jul 17 2014, 11:46 AM
samsonov edited edge metadata.

LGTM

test/asan/TestCases/Posix/waitid.cc
7 ↗(On Diff #11580)

Please sort the includes (unless this order is necessary for FreeBSD).

This revision is now accepted and ready to land.Jul 17 2014, 11:46 AM
kutuzov.viktor.84 updated this revision to Diff 11637.

Closed by commit rL213368 (authored by vkutuzov).