[clang-tidy] Fix one corner case in make-unique check.

[hokein]

Summary

Previously, we tried to cover all "std::initializer_list" implicit conversion
cases in the code, but there are some corner cases that not covered (see
newly-added test in the patch).

Sipping all implicit AST nodes is a better way to filter out all these cases.

[aaron.ballman]

LGTM!

clang-tidy/modernize/MakeSmartPtrCheck.cpp

if (const auto *CE = New->getConstructExpr()) {
         auto IsStdInitListInitConstructExpr = [](const Expr* E) {
           assert(E);
           if (const auto *ImplicitCE = dyn_cast<CXXConstructExpr>(E)) {
             if (ImplicitCE->isStdInitListInitialization())
               return true;
           }
           return false;
         };
-        // Check the implicit conversion from the std::initializer_list type to
-        // a class type.
-        if (IsStdInitListInitConstructExpr(Arg))
+        if (IsStdInitListInitConstructExpr(Arg->IgnoreImplicit()))
           return false;
-        // The Arg can be a CXXBindTemporaryExpr, checking its underlying
-        // construct expr.
-        if (const auto * CTE = dyn_cast<CXXBindTemporaryExpr>(Arg)) {
-          if (IsStdInitListInitConstructExpr(CTE->getSubExpr()))
-            return false;
-        }
       }
     }
     if (ArraySizeExpr.empty()) {
       SourceRange InitRange = New->getDirectInitRange();
       Diag << FixItHint::CreateRemoval(
           SourceRange(NewStart, InitRange.getBegin()));
       Diag << FixItHint::CreateRemoval(SourceRange(InitRange.getEnd(), NewEnd));
     }

test/clang-tidy/modernize-make-unique.cpp

 
 struct G {
   G(std::initializer_list<int>);
   G(int);
 };
 
 struct H {
   H(std::vector<int>);
+  H(std::vector<int> &, double);
   H(MyVector<int>, int);
 };
 
 struct I {
   I(G);
 };
 
 namespace {
void initialization(int T, Base b) {
 
   std::unique_ptr<H> PH2 = std::unique_ptr<H>(new H({1, 2, 3}, 1));
   // CHECK-MESSAGES: :[[@LINE-1]]:28: warning: use std::make_unique instead
   // CHECK-FIXES: std::unique_ptr<H> PH2 = std::unique_ptr<H>(new H({1, 2, 3}, 1));
   PH2.reset(new H({1, 2, 3}, 1));
   // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: use std::make_unique instead
   // CHECK-FIXES: PH2.reset(new H({1, 2, 3}, 1));
 
+  std::unique_ptr<H> PH3 = std::unique_ptr<H>(new H({1, 2, 3}, 1.0));
+  // CHECK-MESSAGES: :[[@LINE-1]]:28: warning: use std::make_unique instead
+  // CHECK-FIXES: std::unique_ptr<H> PH3 = std::unique_ptr<H>(new H({1, 2, 3}, 1.0));
+  PH3.reset(new H({1, 2, 3}, 1.0));
+  // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: use std::make_unique instead
+  // CHECK-FIXES: PH3.reset(new H({1, 2, 3}, 1.0));
+
   std::unique_ptr<I> PI1 = std::unique_ptr<I>(new I(G({1, 2, 3})));
   // CHECK-MESSAGES: :[[@LINE-1]]:28: warning: use std::make_unique instead
   // CHECK-FIXES: std::unique_ptr<I> PI1 = std::make_unique<I>(G({1, 2, 3}));
   PI1.reset(new I(G({1, 2, 3})));
   // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: use std::make_unique instead
   // CHECK-FIXES: PI1 = std::make_unique<I>(G({1, 2, 3}));
 
   std::unique_ptr<Foo> FF = std::unique_ptr<Foo>(new Foo());