Index: include/llvm/CodeGen/GlobalISel/MIPatternMatch.h =================================================================== --- include/llvm/CodeGen/GlobalISel/MIPatternMatch.h +++ include/llvm/CodeGen/GlobalISel/MIPatternMatch.h @@ -142,6 +142,16 @@ } }; +template <> struct bind_helper { + static bool bind(const MachineRegisterInfo &MRI, const ConstantFP *&F, + unsigned Reg) { + F = getConstantFPVRegVal(Reg, MRI); + if (F) + return true; + return false; + } +}; + template struct bind_ty { Class &VR; @@ -156,6 +166,9 @@ inline bind_ty m_MInstr(MachineInstr *&MI) { return MI; } inline bind_ty m_Type(LLT &Ty) { return Ty; } +// Helper for matching G_FCONSTANT +inline bind_ty m_GFCst(const ConstantFP *&C) { return C; } + // General helper for all the binary generic MI such as G_ADD/G_SUB etc template Index: include/llvm/CodeGen/GlobalISel/MachineIRBuilder.h =================================================================== --- include/llvm/CodeGen/GlobalISel/MachineIRBuilder.h +++ include/llvm/CodeGen/GlobalISel/MachineIRBuilder.h @@ -572,6 +572,12 @@ } MachineInstrBuilder buildFConstant(unsigned Res, const ConstantFP &Val); + template + MachineInstrBuilder buildFConstant(DstType &&Res, double Val, const LLT &Ty) { + return buildFConstant(getDestFromArg(Res), Val, Ty); + } + MachineInstrBuilder buildFConstant(unsigned Res, double Val, const LLT &Ty); + /// Build and insert \p Res = COPY Op /// /// Register-to-register COPY sets \p Res to \p Op. Index: include/llvm/CodeGen/GlobalISel/Utils.h =================================================================== --- include/llvm/CodeGen/GlobalISel/Utils.h +++ include/llvm/CodeGen/GlobalISel/Utils.h @@ -33,6 +33,9 @@ class TargetRegisterClass; class Twine; class ConstantFP; +struct fltSemantics; +class APFloat; +class LLT; /// Try to constrain Reg to the specified register class. If this fails, /// create a new virtual register in the correct class and insert a COPY before @@ -99,5 +102,8 @@ MachineInstr *getOpcodeDef(unsigned Opcode, unsigned Reg, const MachineRegisterInfo &MRI); +const fltSemantics &LLTToAPFloatSemantics(const LLT &Ty); + +APFloat getAPFloatFromSize(double Val, unsigned Size); } // End namespace llvm. #endif Index: lib/CodeGen/GlobalISel/MachineIRBuilder.cpp =================================================================== --- lib/CodeGen/GlobalISel/MachineIRBuilder.cpp +++ lib/CodeGen/GlobalISel/MachineIRBuilder.cpp @@ -284,6 +284,13 @@ return buildInstr(TargetOpcode::G_FCONSTANT).addDef(Res).addFPImm(&Val); } +MachineInstrBuilder MachineIRBuilder::buildFConstant(unsigned Res, double Val, + const LLT &Ty) { + auto &Ctx = MF->getFunction().getContext(); + auto *CFP = ConstantFP::get(Ctx, getAPFloatFromSize(Val, Ty.getSizeInBits())); + return buildFConstant(Res, *CFP); +} + MachineInstrBuilder MachineIRBuilder::buildBrCond(unsigned Tst, MachineBasicBlock &Dest) { assert(MRI->getType(Tst).isScalar() && "invalid operand type"); Index: lib/CodeGen/GlobalISel/Utils.cpp =================================================================== --- lib/CodeGen/GlobalISel/Utils.cpp +++ lib/CodeGen/GlobalISel/Utils.cpp @@ -11,6 +11,7 @@ //===----------------------------------------------------------------------===// #include "llvm/CodeGen/GlobalISel/Utils.h" +#include "llvm/ADT/APFloat.h" #include "llvm/ADT/Twine.h" #include "llvm/CodeGen/GlobalISel/RegisterBankInfo.h" #include "llvm/CodeGen/MachineInstr.h" @@ -212,3 +213,34 @@ } return DefMI->getOpcode() == Opcode ? DefMI : nullptr; } + +/// Returns an APFloat semantics tag appropriate for the given type. +const llvm::fltSemantics &llvm::LLTToAPFloatSemantics(const LLT &Ty) { + if (!Ty.isValid()) + llvm_unreachable("Unknown Type"); + switch (Ty.getSizeInBits()) { + case 16: + return APFloat::IEEEhalf(); + case 32: + return APFloat::IEEEsingle(); + case 64: + return APFloat::IEEEdouble(); + default: + llvm_unreachable("Unknown FP format"); + } +} + +/// Returns a APFloat from Val converted to the appropriate size +APFloat llvm::getAPFloatFromSize(double Val, unsigned Size) { + if (Size == 32) + return APFloat(float(Val)); + if (Size == 64) + return APFloat(Val); + if (Size != 16) + llvm_unreachable("Unsupported FPConstant size"); + bool Ignored; + APFloat APF = APFloat(Val); + APF.convert(LLTToAPFloatSemantics(LLT::scalar(Size)), + APFloat::rmNearestTiesToEven, &Ignored); + return APF; +} Index: unittests/CodeGen/GlobalISel/PatternMatchTest.cpp =================================================================== --- unittests/CodeGen/GlobalISel/PatternMatchTest.cpp +++ unittests/CodeGen/GlobalISel/PatternMatchTest.cpp @@ -257,6 +257,43 @@ match = mi_match(MIBFabs->getOperand(0).getReg(), MRI, m_GFabs(m_Reg(Src))); ASSERT_TRUE(match); ASSERT_EQ(Src, Copy0s32->getOperand(0).getReg()); + + // Build and match FConstant. + auto MIBFCst = B.buildFConstant(s32, .5, s32); + const ConstantFP *TmpFP{}; + match = mi_match(MIBFCst->getOperand(0).getReg(), MRI, m_GFCst(TmpFP)); + ASSERT_TRUE(match); + ASSERT_TRUE(TmpFP); + APFloat APF((float).5); + auto *CFP = ConstantFP::get(Context, APF); + ASSERT_EQ(CFP, TmpFP); + + // Build double float. + LLT s64 = LLT::scalar(64); + auto MIBFCst64 = B.buildFConstant(s64, .5, s64); + const ConstantFP *TmpFP64{}; + match = mi_match(MIBFCst64->getOperand(0).getReg(), MRI, m_GFCst(TmpFP64)); + ASSERT_TRUE(match); + ASSERT_TRUE(TmpFP64); + APFloat APF64(.5); + auto CFP64 = ConstantFP::get(Context, APF64); + ASSERT_EQ(CFP64, TmpFP64); + ASSERT_NE(TmpFP64, TmpFP); + + // Build half float. + LLT s16 = LLT::scalar(16); + auto MIBFCst16 = B.buildFConstant(s16, .5, s16); + const ConstantFP *TmpFP16{}; + match = mi_match(MIBFCst16->getOperand(0).getReg(), MRI, m_GFCst(TmpFP16)); + ASSERT_TRUE(match); + ASSERT_TRUE(TmpFP16); + bool Ignored; + APFloat APF16(.5); + APF16.convert(LLTToAPFloatSemantics(s16), APFloat::rmNearestTiesToEven, + &Ignored); + auto CFP16 = ConstantFP::get(Context, APF16); + ASSERT_EQ(TmpFP16, CFP16); + ASSERT_NE(TmpFP16, TmpFP); } TEST(PatternMatchInstr, MatchExtendsTrunc) {