This is an archive of the discontinued LLVM Phabricator instance.

Differential D43976

[GlobalISel][AArch64] Adding Testgen'd tests for InstructionSelect pass
AbandonedPublic

Authored by rtereshin on Mar 1 2018, 3:29 PM.

Details

Reviewers
qcolombet
ab
dsanders
aditya_nandakumar
bogner
volkan
aemerson
t.p.northover
rovka
javed.absar
Summary

Requires https://reviews.llvm.org/D43962, see the review for details.

This commit also removes
test/CodeGen/AArch64/GlobalISel/select-with-no-legality-check.mir
added by https://reviews.llvm.org/rL326396 as containing a strict
subset of the test cases being added by this patch.

Diff Detail

Repository
rL LLVM

Event Timeline

rtereshin created this revision.Mar 1 2018, 3:29 PM
Herald added subscribers: kristof.beyls, javed.absar, rengolin. · View Herald TranscriptMar 1 2018, 3:29 PM
dsanders added a comment.Mar 27 2018, 3:22 PM

Those are quite large tests. How much time does it add to 'ninja check'? If it's reasonably short (I don't really have a number in mind for this) then LGTM. Otherwise we may need to think about trimming it down a bit

rtereshin added a comment.Mar 27 2018, 3:25 PM
In D43976#1049860, @dsanders wrote:

Those are quite large tests. How much time does it add to 'ninja check'? If it's reasonably short (I don't really have a number in mind for this) then LGTM. Otherwise we may need to think about trimming it down a bit

Hi Daniel,

Thanks for looking into this!

I think I have quite detailed perf-data, please find it here: https://reviews.llvm.org/D43962#1026201

Long story short: 1.5 seconds.

dsanders added a comment.Mar 27 2018, 3:25 PM

Also, could you double check the memory usage for this. Some of the bots have a fairly limited amount of memory so the 'ninja check' time will be amplified on those if it consumes a lot.

dsanders added a comment.Mar 27 2018, 3:26 PM

Ah, I'm reading the patches out of order :-). 1.5s seems reasonable

rtereshin abandoned this revision.May 16 2018, 10:09 PM

Dismissing this as outdated.

Herald added a reviewer: javed.absar. · View Herald TranscriptMay 16 2018, 10:09 PM

Revision Contents

Diff 136623

test/CodeGen/AArch64/GlobalISel/arm64-instruction-select-testgen-selected.mir

  • This file was added.
This file has a very large number of changes (48,678 lines). Show File Contents

test/CodeGen/AArch64/GlobalISel/arm64-instruction-select-testgen-testgend.mir

  • This file was added.
This file has a very large number of changes (33,037 lines). Show File Contents

test/CodeGen/AArch64/GlobalISel/select-with-no-legality-check.mir

  • This file was deleted.
This file was completely deleted. Show File Contents