Index: ELF/ScriptParser.cpp =================================================================== --- ELF/ScriptParser.cpp +++ ELF/ScriptParser.cpp @@ -1043,8 +1043,10 @@ } if (Tok == "LENGTH") { StringRef Name = readParenLiteral(); - if (Script->MemoryRegions.count(Name) == 0) + if (Script->MemoryRegions.count(Name) == 0) { setError("memory region not defined: " + Name); + return [=] { return 0; }; + } return [=] { return Script->MemoryRegions[Name]->Length; }; } if (Tok == "LOADADDR") { @@ -1057,8 +1059,10 @@ } if (Tok == "ORIGIN") { StringRef Name = readParenLiteral(); - if (Script->MemoryRegions.count(Name) == 0) + if (Script->MemoryRegions.count(Name) == 0) { setError("memory region not defined: " + Name); + return [=] { return 0; }; + } return [=] { return Script->MemoryRegions[Name]->Origin; }; } if (Tok == "SEGMENT_START") { Index: test/ELF/linkerscript/broken-memory-declaration.s =================================================================== --- test/ELF/linkerscript/broken-memory-declaration.s +++ test/ELF/linkerscript/broken-memory-declaration.s @@ -0,0 +1,10 @@ +# REQUIRES: x86 + +## Check we do not crash. + +# RUN: echo "MEMORY { FLASH (rx) : ORIGIN = 0x1000< LENGTH" > %t.script +# RUN: not ld.lld -o %t --script %t.script 2>&1 | FileCheck %s +# CHECK: unexpected EOF + +# RUN: echo "MEMORY { FLASH (rx) : ORIGIN = 0x1000< ORIGIN" > %t.script +# RUN: not ld.lld -o %t --script %t.script 2>&1 | FileCheck %s