This is an archive of the discontinued LLVM Phabricator instance.

Differential D43786

[LLD] [MinGW] Ignore the --start-group --end-group parameters
ClosedPublic

Authored by mstorsjo on Feb 26 2018, 2:10 PM.

Details

Reviewers
ruiu
rnk
Commits
rGfee5ca722fe3: Merging r326172:
rG41ffd96445e1: [MinGW] Ignore the --start-group --end-group parameters
rL332044: Merging r326172:
rLLD326172: [MinGW] Ignore the --start-group --end-group parameters
rL326172: [MinGW] Ignore the --start-group --end-group parameters
Summary

These are required for handling circular dependencies between static libraries, which is something that lld-link always does without any extra parameters.

Diff Detail

Repository
rL LLVM

Event Timeline

mstorsjo created this revision.Feb 26 2018, 2:10 PM
ruiu accepted this revision.Feb 26 2018, 2:12 PM

LGTM

This revision is now accepted and ready to land.Feb 26 2018, 2:12 PM
Closed by commit rL326172: [MinGW] Ignore the --start-group --end-group parameters (authored by mstorsjo). · Explain WhyFeb 26 2018, 10:28 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lld/
trunk/
MinGW/
2 lines

Diff 136036

lld/trunk/MinGW/Options.td

Show First 20 Lines • Show All 45 Lines • ▼ Show 20 Lines
// Currently stubs to avoid errors // Currently stubs to avoid errors
def Bdynamic: F<"Bdynamic">, HelpText<"Link against shared libraries">; def Bdynamic: F<"Bdynamic">, HelpText<"Link against shared libraries">;
def Bstatic: F<"Bstatic">, HelpText<"Do not link against shared libraries">; def Bstatic: F<"Bstatic">, HelpText<"Do not link against shared libraries">;
def O: Joined<["-"], "O">, HelpText<"Optimize output file size">; def O: Joined<["-"], "O">, HelpText<"Optimize output file size">;
def build_id: F<"build-id">; def build_id: F<"build-id">;
def disable_auto_image_base: F<"disable-auto-image-base">; def disable_auto_image_base: F<"disable-auto-image-base">;
def enable_auto_image_base: F<"enable-auto-image-base">; def enable_auto_image_base: F<"enable-auto-image-base">;
def enable_auto_import: F<"enable-auto-import">; def enable_auto_import: F<"enable-auto-import">;
def end_group: J<"end-group">;
def full_shutdown: Flag<["--"], "full-shutdown">; def full_shutdown: Flag<["--"], "full-shutdown">;
def high_entropy_va: F<"high-entropy-va">, HelpText<"Enable 64-bit ASLR">; def high_entropy_va: F<"high-entropy-va">, HelpText<"Enable 64-bit ASLR">;
def major_image_version: S<"major-image-version">; def major_image_version: S<"major-image-version">;
def minor_image_version: S<"minor-image-version">; def minor_image_version: S<"minor-image-version">;
def no_seh: F<"no-seh">; def no_seh: F<"no-seh">;
def nxcompat: F<"nxcompat">, HelpText<"Enable data execution prevention">; def nxcompat: F<"nxcompat">, HelpText<"Enable data execution prevention">;
def pic_executable: F<"pic-executable">; def pic_executable: F<"pic-executable">;
def sysroot: J<"sysroot">, HelpText<"Sysroot">; def sysroot: J<"sysroot">, HelpText<"Sysroot">;
def start_group: J<"start-group">;
def tsaware: F<"tsaware">, HelpText<"Create Terminal Server aware executable">; def tsaware: F<"tsaware">, HelpText<"Create Terminal Server aware executable">;
def v: Flag<["-"], "v">, HelpText<"Display the version number">; def v: Flag<["-"], "v">, HelpText<"Display the version number">;
def version: F<"version">, HelpText<"Display the version number and exit">; def version: F<"version">, HelpText<"Display the version number and exit">;
// Alias // Alias
def alias_entry_e: JoinedOrSeparate<["-"], "e">, Alias<entry>; def alias_entry_e: JoinedOrSeparate<["-"], "e">, Alias<entry>;
def alias_strip_s: Flag<["-"], "s">, Alias<strip_all>; def alias_strip_s: Flag<["-"], "s">, Alias<strip_all>;