Page MenuHomePhabricator

GCC compatibility: Ignore -finput_charset=UTF-8 argument. It is the default in Clang. Currently, we fail with an error.
ClosedPublic

Authored by sylvestre.ledru on Jun 30 2014, 6:07 AM.

Diff Detail

Event Timeline

sylvestre.ledru retitled this revision from to GCC compatibility: Ignore -finput_charset=UTF-8 argument. It is the default in Clang. Currently, we fail with an error..
sylvestre.ledru updated this object.
sylvestre.ledru edited the test plan for this revision. (Show Details)

Consistency with the other tests (_EQ)

rafael edited edge metadata.Jun 30 2014, 8:28 AM
rafael added a subscriber: Unknown Object (MLST).

Should we error if the argument is not UTF-8?

rnk added a subscriber: rnk.Jun 30 2014, 10:38 AM

I agree, we should only ignore -finput-charset=UTF-8 and reject the rest.

sylvestre.ledru edited edge metadata.

With the error management. Thanks for the feedback.

rafael accepted this revision.Jul 1 2014, 6:10 AM
rafael edited edge metadata.

The formatting looks a bit funny too.

LGTM with the patch clang-formated.

lib/Driver/Tools.cpp
3917

Value

This revision is now accepted and ready to land.Jul 1 2014, 6:10 AM