Index: lib/Target/ARM/AsmParser/ARMAsmParser.cpp =================================================================== --- lib/Target/ARM/AsmParser/ARMAsmParser.cpp +++ lib/Target/ARM/AsmParser/ARMAsmParser.cpp @@ -4238,6 +4238,18 @@ MCAsmParser &Parser = getParser(); SMLoc S = Parser.getTok().getLoc(); const AsmToken &Tok = Parser.getTok(); + + if (Tok.is(AsmToken::Integer)) { + int64_t Val = Tok.getIntVal(); + if (Val > 255 || Val < 0) { + return MatchOperand_NoMatch; + } + unsigned SYSmvalue = Val & 0xFFF; + Parser.Lex(); + Operands.push_back(ARMOperand::CreateMSRMask(SYSmvalue, S)); + return MatchOperand_Success; + } + if (!Tok.is(AsmToken::Identifier)) return MatchOperand_NoMatch; StringRef Mask = Tok.getString(); Index: lib/Target/ARM/Disassembler/ARMDisassembler.cpp =================================================================== --- lib/Target/ARM/Disassembler/ARMDisassembler.cpp +++ lib/Target/ARM/Disassembler/ARMDisassembler.cpp @@ -4149,7 +4149,6 @@ case 0x8a: // msplim_ns case 0x8b: // psplim_ns case 0x91: // basepri_ns - case 0x92: // basepri_max_ns case 0x93: // faultmask_ns if (!(FeatureBits[ARM::HasV8MMainlineOps])) return MCDisassembler::Fail; @@ -4165,7 +4164,9 @@ return MCDisassembler::Fail; break; default: - return MCDisassembler::Fail; + // Architecturally defined as unpredictable + S = MCDisassembler::SoftFail; + break; } if (Inst.getOpcode() == ARM::t2MSR_M) { Index: lib/Target/ARM/InstPrinter/ARMInstPrinter.cpp =================================================================== --- lib/Target/ARM/InstPrinter/ARMInstPrinter.cpp +++ lib/Target/ARM/InstPrinter/ARMInstPrinter.cpp @@ -825,7 +825,8 @@ return; } - llvm_unreachable("Unexpected mask value!"); + O << SYSm; + return; } Index: test/MC/ARM/thumbv8m.s =================================================================== --- test/MC/ARM/thumbv8m.s +++ test/MC/ARM/thumbv8m.s @@ -225,6 +225,12 @@ // CHECK-MAINLINE: msr faultmask_ns, lr @ encoding: [0x8e,0xf3,0x93,0x88] // UNDEF-BASELINE: error: invalid operand for instruction +// Unpredictable SYSm's +MRS r8, 146 +// CHECK: mrs r8, 146 @ encoding: [0xef,0xf3,0x92,0x88] +MSR 146, r8 +// CHECK: msr 146, r8 @ encoding: [0x88,0xf3,0x92,0x80] + // Invalid operand tests // UNDEF: error: too many operands for instruction // UNDEF: sg #0 Index: test/MC/Disassembler/ARM/invalid-thumb-MSR-MClass.txt =================================================================== --- test/MC/Disassembler/ARM/invalid-thumb-MSR-MClass.txt +++ test/MC/Disassembler/ARM/invalid-thumb-MSR-MClass.txt @@ -1,5 +1,5 @@ -# RUN: not llvm-mc -disassemble %s -triple=thumbv7em 2>&1 | FileCheck %s -# RUN: not llvm-mc -disassemble %s -triple=thumbv7m 2>&1 | FileCheck --check-prefix=CHECK --check-prefix=CHECK-V7M %s +# RUN: llvm-mc -disassemble %s -triple=thumbv7em 2>&1 | FileCheck %s +# RUN: llvm-mc -disassemble %s -triple=thumbv7m 2>&1 | FileCheck --check-prefix=CHECK --check-prefix=CHECK-V7M %s #------------------------------------------------------------------------------ # Undefined encodings for mrs @@ -6,7 +6,7 @@ #------------------------------------------------------------------------------ # invalid SYSm -# CHECK: warning: invalid instruction encoding +# CHECK: warning: potentially undefined instruction encoding # CHECK-NEXT: [0xef 0xf3 0x80 0x80] [0xef 0xf3 0x80 0x80] @@ -30,6 +30,6 @@ [0x80 0xf3 0x00 0x84] # invalid SYSm -# CHECK: warning: invalid instruction encoding +# CHECK: warning: potentially undefined instruction encoding # CHECK-NEXT: [0x80 0xf3 0x80 0x88] [0x80 0xf3 0x80 0x88]