This is an archive of the discontinued LLVM Phabricator instance.

limits: Use `false` instead of `type(0)`.
Needs ReviewPublic

Authored by brucem on Feb 13 2018, 8:47 PM.

Details

Summary

This fixes warnings when using clang-tidy and the
modernize-use-bool-literals check.

Event Timeline

brucem created this revision.Feb 13 2018, 8:47 PM

I see no benefit to this change. bool(0) is false.

Without this, anyone using clang-tidy with this check gets 6 system header warnings whenever they transitively have included limits.

Without this, anyone using clang-tidy with this check gets 6 system header warnings whenever they transitively have included limits.

Only if -system-headers is passed to clang-tidy, or if those libc++ headers are included as normal includes (-I), and not as system includes (-isystem).