Index: lib/Analysis/MemorySSA.cpp =================================================================== --- lib/Analysis/MemorySSA.cpp +++ lib/Analysis/MemorySSA.cpp @@ -234,12 +234,12 @@ if (const IntrinsicInst *II = dyn_cast(DefInst)) { // These intrinsics will show up as affecting memory, but they are just - // markers. + // markers, mostly. switch (II->getIntrinsicID()) { case Intrinsic::lifetime_start: if (UseCS) return false; - return AA.isMustAlias(MemoryLocation(II->getArgOperand(1)), UseLoc); + return !AA.isNoAlias(MemoryLocation(II->getArgOperand(1)), UseLoc); case Intrinsic::lifetime_end: case Intrinsic::invariant_start: case Intrinsic::invariant_end: Index: test/Transforms/EarlyCSE/memoryssa.ll =================================================================== --- test/Transforms/EarlyCSE/memoryssa.ll +++ test/Transforms/EarlyCSE/memoryssa.ll @@ -106,3 +106,45 @@ store i32 %v2, i32* @G3 ret void } + +;; Check that we respect lifetime.start/lifetime.end intrinsics when deleting +;; stores that, without the lifetime calls, would be writebacks. +; CHECK-LABEL: @test_writeback_lifetimes( +; CHECK-NOMEMSSA-LABEL: @test_writeback_lifetimes( +define void @test_writeback_lifetimes(i32* %p) { +entry: + %q = getelementptr i32, i32* %p, i64 1 + %pv = load i32, i32* %p + %qv = load i32, i32* %q + call void @llvm.lifetime.end.p0i8(i64 8, i32* %p) + call void @llvm.lifetime.start.p0i8(i64 8, i32* %p) + ; CHECK: store i32 %pv + ; CHECK-NOMEMSSA-LABEL: store i32 %pv + store i32 %pv, i32* %p + ; CHECK: store i32 %qv, i32* %q + ; CHECK-NOMEMSSA-LABEL: store i32 %qv, i32* %q + store i32 %qv, i32* %q + ret void +} + +;; Check that we respect lifetime.start/lifetime.end intrinsics when deleting +;; stores that, without the lifetime calls, would be writebacks. +; CHECK-LABEL: @test_writeback_lifetimes_multi_arg( +; CHECK-NOMEMSSA-LABEL: @test_writeback_lifetimes_multi_arg( +define void @test_writeback_lifetimes_multi_arg(i32* %p, i32* %q) { +entry: + %pv = load i32, i32* %p + %qv = load i32, i32* %q + call void @llvm.lifetime.end.p0i8(i64 8, i32* %p) + call void @llvm.lifetime.start.p0i8(i64 8, i32* %p) + ; CHECK: store i32 %pv + ; CHECK-NOMEMSSA-LABEL: store i32 %pv + store i32 %pv, i32* %p + ; CHECK: store i32 %qv, i32* %q + ; CHECK-NOMEMSSA-LABEL: store i32 %qv, i32* %q + store i32 %qv, i32* %q + ret void +} + +declare void @llvm.lifetime.end.p0i8(i64, i32*) +declare void @llvm.lifetime.start.p0i8(i64, i32*) Index: unittests/Analysis/MemorySSA.cpp =================================================================== --- unittests/Analysis/MemorySSA.cpp +++ unittests/Analysis/MemorySSA.cpp @@ -909,3 +909,69 @@ Updater.insertUse(LoadAccess); MSSA.verifyMemorySSA(); } + +TEST_F(MemorySSATest, LifetimeMarkersAreClobbers) { + // Example code: + // define void @a(i8* %foo) { + // %bar = getelementptr i8, i8* %foo, i64 1 + // store i8 0, i8* %foo + // store i8 0, i8* %bar + // call void @llvm.lifetime.end.p0i8(i64 8, i32* %p) + // call void @llvm.lifetime.start.p0i8(i64 8, i32* %p) + // store i8 0, i8* %foo + // store i8 0, i8* %bar + // ret void + // } + // + // Patterns like this are possible after inlining; the stores to %foo and %bar + // should both be clobbered by the lifetime.start call if they're dominated by + // it. + + IRBuilder<> B(C); + F = Function::Create( + FunctionType::get(B.getVoidTy(), {B.getInt8PtrTy()}, false), + GlobalValue::ExternalLinkage, "F", &M); + + // Make blocks + BasicBlock *Entry = BasicBlock::Create(C, "entry", F); + + B.SetInsertPoint(Entry); + Value *Foo = &*F->arg_begin(); + + Value *Bar = B.CreateGEP(Foo, B.getInt64(1), "bar"); + + B.CreateStore(B.getInt8(0), Foo); + B.CreateStore(B.getInt8(0), Bar); + + auto GetLifetimeIntrinsic = [&](Intrinsic::ID ID) { + return Intrinsic::getDeclaration(&M, ID, {Foo->getType()}); + }; + + B.CreateCall(GetLifetimeIntrinsic(Intrinsic::lifetime_end), + {B.getInt64(2), Foo}); + Instruction *LifetimeStart = B.CreateCall( + GetLifetimeIntrinsic(Intrinsic::lifetime_start), {B.getInt64(2), Foo}); + + Instruction *FooStore = B.CreateStore(B.getInt8(0), Foo); + Instruction *BarStore = B.CreateStore(B.getInt8(0), Bar); + + setupAnalyses(); + MemorySSA &MSSA = *Analyses->MSSA; + + MemoryAccess *LifetimeStartAccess = MSSA.getMemoryAccess(LifetimeStart); + ASSERT_NE(LifetimeStartAccess, nullptr); + + MemoryAccess *FooAccess = MSSA.getMemoryAccess(FooStore); + ASSERT_NE(FooAccess, nullptr); + + MemoryAccess *BarAccess = MSSA.getMemoryAccess(BarStore); + ASSERT_NE(BarAccess, nullptr); + + MemoryAccess *FooClobber = + MSSA.getWalker()->getClobberingMemoryAccess(FooAccess); + EXPECT_EQ(FooClobber, LifetimeStartAccess); + + MemoryAccess *BarClobber = + MSSA.getWalker()->getClobberingMemoryAccess(BarAccess); + EXPECT_EQ(BarClobber, LifetimeStartAccess); +}