Page MenuHomePhabricator

ARM: take care not to set the ThumbFunc bit on TLS data symbols
ClosedPublic

Authored by scott-0 on Jun 27 2014, 7:04 AM.

Details

Summary

MCELF::GetType() returns an enumeration but it was being treated as a bitmask.

This fixes LNT SingleSource/UnitTests/Threads with -mthumb

Diff Detail

Repository
rL LLVM

Event Timeline

scott-0 updated this revision to Diff 10932.Jun 27 2014, 7:04 AM
scott-0 retitled this revision from to ARM: take care not to set the ThumbFunc bit on TLS data symbols.
scott-0 updated this object.
scott-0 edited the test plan for this revision. (Show Details)
scott-0 added a reviewer: compnerd.
scott-0 set the repository for this revision to rL LLVM.
scott-0 added a subscriber: Unknown Object (MLST).
mroth added a subscriber: mroth.Jun 27 2014, 7:06 AM
compnerd accepted this revision.Jun 27 2014, 7:11 AM
compnerd edited edge metadata.

Nice find! Thanks for fixing this.

This revision is now accepted and ready to land.Jun 27 2014, 7:11 AM

Hi Scott,

Do you have commit rights?

--renato

I just got them; thanks.

scott-0 closed this revision.Jun 30 2014, 2:45 AM
scott-0 updated this revision to Diff 10972.

Closed by commit rL212029 (authored by @scott-0).