This is an archive of the discontinued LLVM Phabricator instance.

Use EXPECT_FALSE instead of EXPECT_EQ(false, ...
ClosedPublic

Authored by chill on Feb 13 2018, 5:59 AM.

Details

Summary

Commit https://reviews.llvm.org/rL324489 added

EXPECT_EQ(false, N->isUnsigned());

which older GCC versions dislike for some reason. Anyway, it looks like the proper GTest way
is to use EXPECT_FALSE, etc.

Diff Detail

Repository
rL LLVM

Event Timeline

chill created this revision.Feb 13 2018, 5:59 AM
gkistanova accepted this revision.Feb 13 2018, 1:13 PM

LGTM.
This seems a proper GTest way, indeed.
Just for the record, the warning was reported by clang 5.0.1.

This revision is now accepted and ready to land.Feb 13 2018, 1:13 PM
This revision was automatically updated to reflect the committed changes.