Index: llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp =================================================================== --- llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp +++ llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp @@ -5398,7 +5398,7 @@ } // fold (not (or x, y)) -> (and (not x), (not y)) iff x or y are setcc - if (isOneConstant(N1) && VT == MVT::i1 && + if (isOneConstant(N1) && VT == MVT::i1 && N0.hasOneUse() && (N0.getOpcode() == ISD::OR || N0.getOpcode() == ISD::AND)) { SDValue LHS = N0.getOperand(0), RHS = N0.getOperand(1); if (isOneUseSetCC(RHS) || isOneUseSetCC(LHS)) { @@ -5410,7 +5410,7 @@ } } // fold (not (or x, y)) -> (and (not x), (not y)) iff x or y are constants - if (isAllOnesConstant(N1) && + if (isAllOnesConstant(N1) && N0.hasOneUse() && (N0.getOpcode() == ISD::OR || N0.getOpcode() == ISD::AND)) { SDValue LHS = N0.getOperand(0), RHS = N0.getOperand(1); if (isa(RHS) || isa(LHS)) { Index: llvm/trunk/test/CodeGen/X86/tbm_patterns.ll =================================================================== --- llvm/trunk/test/CodeGen/X86/tbm_patterns.ll +++ llvm/trunk/test/CodeGen/X86/tbm_patterns.ll @@ -907,17 +907,12 @@ ret i64 %and } -; This should select blcic -; TODO: the xor is being combined with the mask and creating an or that's breaking this. Looks like a missing one use check. +; Make sure the mask doesn't break our matching of blcic define i64 @masked_blcic(i64) { ; CHECK-LABEL: masked_blcic: ; CHECK: # %bb.0: ; CHECK-NEXT: movzwl %di, %eax -; CHECK-NEXT: # kill: def $edi killed $edi killed $rdi def $rdi -; CHECK-NEXT: notl %edi -; CHECK-NEXT: orq $-65536, %rdi # imm = 0xFFFF0000 -; CHECK-NEXT: incq %rax -; CHECK-NEXT: andq %rdi, %rax +; CHECK-NEXT: blcicl %eax, %eax ; CHECK-NEXT: retq %2 = and i64 %0, 65535 %3 = xor i64 %2, -1