Index: lib/AST/MicrosoftMangle.cpp =================================================================== --- lib/AST/MicrosoftMangle.cpp +++ lib/AST/MicrosoftMangle.cpp @@ -362,6 +362,10 @@ const TemplateArgumentList &TemplateArgs); void mangleTemplateArg(const TemplateDecl *TD, const TemplateArgument &TA, const NamedDecl *Parm); + + void mangleObjCProtocol(const ObjCProtocolDecl *PD); + void mangleObjCLifetime(const QualType T, Qualifiers Quals, + SourceRange Range); }; } @@ -1456,6 +1460,47 @@ } } +void MicrosoftCXXNameMangler::mangleObjCProtocol(const ObjCProtocolDecl *PD) { + llvm::SmallString<64> TemplateMangling; + llvm::raw_svector_ostream Stream(TemplateMangling); + MicrosoftCXXNameMangler Extra(Context, Stream); + + Stream << "?$"; + Extra.mangleSourceName("Protocol"); + Extra.mangleArtificalTagType(TTK_Struct, PD->getName()); + + mangleArtificalTagType(TTK_Struct, TemplateMangling, {"__ObjC"}); +} + +void MicrosoftCXXNameMangler::mangleObjCLifetime(const QualType Type, + Qualifiers Quals, + SourceRange Range) { + llvm::SmallString<64> TemplateMangling; + llvm::raw_svector_ostream Stream(TemplateMangling); + MicrosoftCXXNameMangler Extra(Context, Stream); + + Stream << "?$"; + switch (Quals.getObjCLifetime()) { + case Qualifiers::OCL_None: + case Qualifiers::OCL_ExplicitNone: + break; + case Qualifiers::OCL_Autoreleasing: + Extra.mangleSourceName("Autoreleasing"); + break; + case Qualifiers::OCL_Strong: + Extra.mangleSourceName("Strong"); + break; + case Qualifiers::OCL_Weak: + Extra.mangleSourceName("Weak"); + break; + } + Extra.manglePointerCVQualifiers(Quals); + Extra.manglePointerExtQualifiers(Quals, Type); + Extra.mangleType(Type, Range); + + mangleArtificalTagType(TTK_Struct, TemplateMangling, {"__ObjC"}); +} + void MicrosoftCXXNameMangler::mangleQualifiers(Qualifiers Quals, bool IsMember) { // ::= [E] [F] [I] @@ -1683,6 +1728,8 @@ switch (QMM) { case QMM_Drop: + if (Quals.hasObjCLifetime()) + Quals = Quals.withoutObjCLifetime(); break; case QMM_Mangle: if (const FunctionType *FT = dyn_cast(T)) { @@ -1701,6 +1748,8 @@ case QMM_Result: // Presence of __unaligned qualifier shouldn't affect mangling here. Quals.removeUnaligned(); + if (Quals.hasObjCLifetime()) + Quals = Quals.withoutObjCLifetime(); if ((!IsPointer && Quals) || isa(T)) { Out << '?'; mangleQualifiers(Quals, false); @@ -2334,6 +2383,15 @@ void MicrosoftCXXNameMangler::mangleType(const ObjCObjectPointerType *T, Qualifiers Quals, SourceRange Range) { QualType PointeeType = T->getPointeeType(); + switch (Quals.getObjCLifetime()) { + case Qualifiers::OCL_None: + case Qualifiers::OCL_ExplicitNone: + break; + case Qualifiers::OCL_Autoreleasing: + case Qualifiers::OCL_Strong: + case Qualifiers::OCL_Weak: + return mangleObjCLifetime(PointeeType, Quals, Range); + } manglePointerCVQualifiers(Quals); manglePointerExtQualifiers(Quals, PointeeType); mangleType(PointeeType, Range); @@ -2469,11 +2527,8 @@ else mangleSourceName(T->getInterface()->getName()); - for (const auto &Q : T->quals()) { - Out << 'Y'; // cointerface - mangleSourceName(Q->getName()); - Out << '@'; - } + for (const auto &Q : T->quals()) + mangleObjCProtocol(Q); Out << '@'; Out << '@'; Index: test/CodeGenObjCXX/msabi-objc-extensions.mm =================================================================== --- /dev/null +++ test/CodeGenObjCXX/msabi-objc-extensions.mm @@ -0,0 +1,66 @@ +// RUN: %clang_cc1 -triple thumbv7-windows-msvc -fobjc-runtime=ios-6.0 -fobjc-arc -o - -emit-llvm %s | FileCheck %s + +@protocol P; +@protocol Q; + +@class I; + +void f(id

, id, id

, id) {} +// CHECK-LABEL: "\01?f@@YAXPAU?$objc_object@U?$Protocol@UP@@@__ObjC@@@@PAUobjc_object@@01@Z" + +void f(id, id

, id

, id) {} +// CHECK-LABEL: "\01?f@@YAXPAUobjc_object@@PAU?$objc_object@U?$Protocol@UP@@@__ObjC@@@@10@Z" + +void f(id

, id

) {} +// CHECK-LABEL: "\01?f@@YAXPAU?$objc_object@U?$Protocol@UP@@@__ObjC@@@@0@Z" + +void f(id

) {} +// CHECK-LABEL: "\01?f@@YAXPAU?$objc_object@U?$Protocol@UP@@@__ObjC@@@@@Z" + +void f(id) {} +// CHECK-LABEL: "\01?f@@YAXPAU?$objc_object@U?$Protocol@UP@@@__ObjC@@U?$Protocol@UQ@@@2@@@@Z" + +void f(Class

) {} +// CHECK-LABEL: "\01?f@@YAXPAU?$objc_class@U?$Protocol@UP@@@__ObjC@@@@@Z" + +void f(Class) {} +// CHECK-LABEL: "\01?f@@YAXPAU?$objc_class@U?$Protocol@UP@@@__ObjC@@U?$Protocol@UQ@@@2@@@@Z" + +void f(I

*) {} +// CHECK-LABEL: "\01?f@@YAXPAU?$I@U?$Protocol@UP@@@__ObjC@@@@@Z" + +void f(I *) {} +// CHECK-LABEL: "\01?f@@YAXPAU?$I@U?$Protocol@UP@@@__ObjC@@U?$Protocol@UQ@@@2@@@@Z" + +template +struct S {}; + +void f(S<__unsafe_unretained id>) {} +// CHECK-LABEL: "\01?f@@YAXU?$S@PAUobjc_object@@@@@Z" + +void f(S<__autoreleasing id>) {} +// CHECK-LABEL: "\01?f@@YAXU?$S@U?$Autoreleasing@PAUobjc_object@@@__ObjC@@@@@Z" + +void f(S<__strong id>) {} +// CHECK-LABEL: "\01?f@@YAXU?$S@U?$Strong@PAUobjc_object@@@__ObjC@@@@@Z" + +void f(S<__weak id>) {} +// CHECK-LABEL: "\01?f@@YAXU?$S@U?$Weak@PAUobjc_object@@@__ObjC@@@@@Z" + +void w(__weak id) {} +// CHECK-LABEL: "\01?w@@YAXPAUobjc_object@@@Z" + +void s(__strong id) {} +// CHECK-LABEL: "\01?s@@YAXPAUobjc_object@@@Z" + +void a(__autoreleasing id) {} +// CHECK-LABEL: "\01?a@@YAXPAUobjc_object@@@Z" + +void u(__unsafe_unretained id) {} +// CHECK-LABEL: "\01?u@@YAXPAUobjc_object@@@Z" + +S<__autoreleasing id> g() { return S<__autoreleasing id>(); } +// CHECK-LABEL: "\01?g@@YA?AU?$S@U?$Autoreleasing@PAUobjc_object@@@__ObjC@@@@XZ" + +__autoreleasing id h() { return nullptr; } +// CHECK-LABEL: "\01?h@@YAPAUobjc_object@@XZ" Index: test/CodeGenObjCXX/msabi-protocol-conformance.mm =================================================================== --- test/CodeGenObjCXX/msabi-protocol-conformance.mm +++ /dev/null @@ -1,34 +0,0 @@ -// RUN: %clang_cc1 -triple thumbv7-windows-msvc -fobjc-runtime=ios-6.0 -o - -emit-llvm %s | FileCheck %s - -@protocol P; -@protocol Q; - -@class I; - -void f(id

, id, id

, id) {} -// CHECK-LABEL: "\01?f@@YAXPAU?$objc_object@YP@@@@PAUobjc_object@@01@Z" - -void f(id, id

, id

, id) {} -// CHECK-LABEL: "\01?f@@YAXPAUobjc_object@@PAU?$objc_object@YP@@@@10@Z" - -void f(id

, id

) {} -// CHECK-LABEL: "\01?f@@YAXPAU?$objc_object@YP@@@@0@Z" - -void f(id

) {} -// CHECK-LABEL: "\01?f@@YAXPAU?$objc_object@YP@@@@@Z" - -void f(id) {} -// CHECK-LABEL: "\01?f@@YAXPAU?$objc_object@YP@@YQ@@@@@Z" - -void f(Class

) {} -// CHECK-LABEL: "\01?f@@YAXPAU?$objc_class@YP@@@@@Z" - -void f(Class) {} -// CHECK-LABEL: "\01?f@@YAXPAU?$objc_class@YP@@YQ@@@@@Z" - -void f(I

*) {} -// CHECK-LABEL: "\01?f@@YAXPAU?$I@YP@@@@@Z" - -void f(I *) {} -// CHECK-LABEL: "\01?f@@YAXPAU?$I@YP@@YQ@@@@@Z" -