This is an archive of the discontinued LLVM Phabricator instance.

asan: allow inline instrumentation for the kernel
ClosedPublic

Authored by andreyknvl on Jan 22 2018, 10:35 AM.

Download Raw Diff

Details

Reviewers

dvyukov
kcc
eugenis

Summary

Currently ASan instrumentation pass forces callback instrumentation when applied to the kernel. This patch changes the current behavior to allow using inline instrumentation in this case.

Diff Detail

Event Timeline

andreyknvl created this revision.Jan 22 2018, 10:35 AM

dvyukov accepted this revision.Jan 22 2018, 10:40 AM

This revision is now accepted and ready to land.Jan 22 2018, 10:40 AM

Committed in r323140.

@andreyknvl could you please add a test for this?

Sent https://reviews.llvm.org/D42473

Revision Contents

Path

Size

lib/

Transforms/

Instrumentation/

AddressSanitizer.cpp

1 line

Diff 130923

lib/Transforms/Instrumentation/AddressSanitizer.cpp

Show First 20 Lines • Show All 2,488 Lines • ▼ Show 20 Lines	for (auto &Inst : BB) {
}		}
ToInstrument.push_back(&Inst);		ToInstrument.push_back(&Inst);
NumInsnsPerBB++;		NumInsnsPerBB++;
if (NumInsnsPerBB >= ClMaxInsnsToInstrumentPerBB) break;		if (NumInsnsPerBB >= ClMaxInsnsToInstrumentPerBB) break;
}		}
}		}

bool UseCalls =		bool UseCalls =
CompileKernel \|\|
(ClInstrumentationWithCallsThreshold >= 0 &&		(ClInstrumentationWithCallsThreshold >= 0 &&
ToInstrument.size() > (unsigned)ClInstrumentationWithCallsThreshold);		ToInstrument.size() > (unsigned)ClInstrumentationWithCallsThreshold);
const DataLayout &DL = F.getParent()->getDataLayout();		const DataLayout &DL = F.getParent()->getDataLayout();
ObjectSizeOpts ObjSizeOpts;		ObjectSizeOpts ObjSizeOpts;
ObjSizeOpts.RoundToAlign = true;		ObjSizeOpts.RoundToAlign = true;
ObjectSizeOffsetVisitor ObjSizeVis(DL, TLI, F.getContext(), ObjSizeOpts);		ObjectSizeOffsetVisitor ObjSizeVis(DL, TLI, F.getContext(), ObjSizeOpts);

// Instrument.		// Instrument.
▲ Show 20 Lines • Show All 667 Lines • Show Last 20 Lines