Index: include/llvm/MC/MCSymbol.h =================================================================== --- include/llvm/MC/MCSymbol.h +++ include/llvm/MC/MCSymbol.h @@ -177,8 +177,8 @@ llvm_unreachable("Constructor throws?"); } - MCSection *getSectionPtr(bool SetUsed = true) const { - if (MCFragment *F = getFragment(SetUsed)) { + MCSection *getSectionPtr() const { + if (MCFragment *F = getFragment()) { assert(F != AbsolutePseudoFragment); return F->getParent(); } @@ -221,7 +221,6 @@ /// isUsed - Check if this is used. bool isUsed() const { return IsUsed; } - void setUsed(bool Value) const { IsUsed |= Value; } /// \brief Check if this symbol is redefinable. bool isRedefinable() const { return IsRedefinable; } @@ -246,28 +245,28 @@ /// isDefined - Check if this symbol is defined (i.e., it has an address). /// /// Defined symbols are either absolute or in some section. - bool isDefined(bool SetUsed = true) const { - return getFragment(SetUsed) != nullptr; - } + bool isDefined() const { return !isUndefined(); } /// isInSection - Check if this symbol is defined in some section (i.e., it /// is defined but not absolute). - bool isInSection(bool SetUsed = true) const { - return isDefined(SetUsed) && !isAbsolute(SetUsed); + bool isInSection() const { + return isDefined() && !isAbsolute(); } /// isUndefined - Check if this symbol undefined (i.e., implicitly defined). - bool isUndefined(bool SetUsed = true) const { return !isDefined(SetUsed); } + bool isUndefined(bool SetUsed = true) const { + return getFragment(SetUsed) == nullptr; + } /// isAbsolute - Check if this is an absolute symbol. - bool isAbsolute(bool SetUsed = true) const { - return getFragment(SetUsed) == AbsolutePseudoFragment; + bool isAbsolute() const { + return getFragment() == AbsolutePseudoFragment; } /// Get the section associated with a defined, non-absolute symbol. - MCSection &getSection(bool SetUsed = true) const { - assert(isInSection(SetUsed) && "Invalid accessor!"); - return *getSectionPtr(SetUsed); + MCSection &getSection() const { + assert(isInSection() && "Invalid accessor!"); + return *getSectionPtr(); } /// Mark the symbol as defined in the fragment \p F. Index: lib/MC/MCCodeView.cpp =================================================================== --- lib/MC/MCCodeView.cpp +++ lib/MC/MCCodeView.cpp @@ -507,7 +507,7 @@ if (!LocAfter.empty()) { // Only try to compute this difference if we're in the same section. const MCCVLineEntry &Loc = LocAfter[0]; - if (&Loc.getLabel()->getSection(false) == &LastLabel->getSection(false)) + if (&Loc.getLabel()->getSection() == &LastLabel->getSection()) LocAfterLength = computeLabelDiff(Layout, LastLabel, Loc.getLabel()); } Index: lib/Target/Hexagon/MCTargetDesc/HexagonMCELFStreamer.cpp =================================================================== --- lib/Target/Hexagon/MCTargetDesc/HexagonMCELFStreamer.cpp +++ lib/Target/Hexagon/MCTargetDesc/HexagonMCELFStreamer.cpp @@ -124,7 +124,7 @@ MCSectionSubPair P = getCurrentSection(); SwitchSection(&Section); - if (ELFSymbol->isUndefined(false)) { + if (ELFSymbol->isUndefined()) { EmitValueToAlignment(ByteAlignment, 0, 1, 0); EmitLabel(Symbol); EmitZeros(Size);