Index: test/tools/llvm-objcopy/localize-hidden.test =================================================================== --- /dev/null +++ test/tools/llvm-objcopy/localize-hidden.test @@ -0,0 +1,141 @@ +# RUN: yaml2obj %s > %t +# RUN: llvm-objcopy -localize-hidden %t %t2 +# RUN: llvm-readobj -relocations -symbols %t2 | FileCheck %s + +!ELF +FileHeader: + Class: ELFCLASS64 + Data: ELFDATA2LSB + Type: ET_REL + Machine: EM_X86_64 +Sections: + - Name: .text + Type: SHT_PROGBITS + Flags: [ SHF_ALLOC, SHF_EXECINSTR ] + Address: 0x1000 + AddressAlign: 0x0000000000000010 + Size: 64 + - Name: .data + Type: SHT_PROGBITS + Flags: [ SHF_ALLOC ] + Address: 0x2000 + AddressAlign: 0x0000000000000010 + Content: "0000000000000000" + - Name: .rel.text + Type: SHT_REL + Info: .text + Relocations: + - Offset: 0x1000 + Symbol: foo + Type: R_X86_64_PC32 + - Offset: 0x1004 + Symbol: baz + Type: R_X86_64_PC32 +Symbols: + Global: + - Name: _start + Type: STT_FUNC + Size: 8 + Section: .text + Value: 0x1000 + - Name: bam + Type: STT_FUNC + Section: .text + Value: 0x1008 + Size: 8 + Visibility: STV_HIDDEN + - Name: foo + Type: STT_FUNC + Size: 8 + - Name: faz + Type: STT_OBJECT + Section: .data + Value: 0x2002 + Size: 2 + Visibility: STV_INTERNAL + - Name: bar + Type: STT_OBJECT + Section: .data + Value: 0x2000 + Size: 4 + - Name: baz + Type: STT_OBJECT + Size: 4 + +#CHECK: Relocations [ +#CHECK-NEXT: Section (3) .rel.text { +#CHECK-NEXT: 0x1000 R_X86_64_PC32 foo 0x0 +#CHECK-NEXT: 0x1004 R_X86_64_PC32 baz 0x0 +#CHECK-NEXT: } +#CHECK-NEXT:] + + +#CHECK: Symbols [ +#CHECK-NEXT: Symbol { +#CHECK-NEXT: Name: +#CHECK-NEXT: Value: 0x0 +#CHECK-NEXT: Size: 0 +#CHECK-NEXT: Binding: Local +#CHECK-NEXT: Type: None +#CHECK-NEXT: Other: 0 +#CHECK-NEXT: Section: Undefined +#CHECK-NEXT: } +#CHECK-NEXT: Symbol { +#CHECK-NEXT: Name: bam +#CHECK-NEXT: Value: 0x1008 +#CHECK-NEXT: Size: 8 +#CHECK-NEXT: Binding: Local +#CHECK-NEXT: Type: Function +#CHECK-NEXT: Other [ +#CHECK-NEXT: STV_HIDDEN +#CHECK-NEXT: ] +#CHECK-NEXT: Section: .text +#CHECK-NEXT: } +#CHECK-NEXT: Symbol { +#CHECK-NEXT: Name: faz +#CHECK-NEXT: Value: 0x2002 +#CHECK-NEXT: Size: 2 +#CHECK-NEXT: Binding: Local +#CHECK-NEXT: Type: Object +#CHECK-NEXT: Other [ +#CHECK-NEXT: STV_INTERNAL +#CHECK-NEXT: ] +#CHECK-NEXT: Section: .data +#CHECK-NEXT: } +#CHECK-NEXT: Symbol { +#CHECK-NEXT: Name: _start +#CHECK-NEXT: Value: 0x1000 +#CHECK-NEXT: Size: 8 +#CHECK-NEXT: Binding: Global +#CHECK-NEXT: Type: Function +#CHECK-NEXT: Other: 0 +#CHECK-NEXT: Section: .text +#CHECK-NEXT: } +#CHECK-NEXT: Symbol { +#CHECK-NEXT: Name: foo +#CHECK-NEXT: Value: 0x0 +#CHECK-NEXT: Size: 8 +#CHECK-NEXT: Binding: Global +#CHECK-NEXT: Type: Function +#CHECK-NEXT: Other: 0 +#CHECK-NEXT: Section: +#CHECK-NEXT: } +#CHECK-NEXT: Symbol { +#CHECK-NEXT: Name: bar +#CHECK-NEXT: Value: 0x2000 +#CHECK-NEXT: Size: 4 +#CHECK-NEXT: Binding: Global +#CHECK-NEXT: Type: Object +#CHECK-NEXT: Other: 0 +#CHECK-NEXT: Section: .data +#CHECK-NEXT: } +#CHECK-NEXT: Symbol { +#CHECK-NEXT: Name: baz +#CHECK-NEXT: Value: 0x0 +#CHECK-NEXT: Size: 4 +#CHECK-NEXT: Binding: Global +#CHECK-NEXT: Type: Object +#CHECK-NEXT: Other: 0 +#CHECK-NEXT: Section: +#CHECK-NEXT: } +#CHECK-NEXT:] Index: tools/llvm-objcopy/Object.h =================================================================== --- tools/llvm-objcopy/Object.h +++ tools/llvm-objcopy/Object.h @@ -214,6 +214,7 @@ const SectionBase *getStrTab() const { return SymbolNames; } const Symbol *getSymbolByIndex(uint32_t Index) const; void removeSectionReferences(const SectionBase *Sec) override; + void localize(std::function ToLocalize); void initialize(SectionTableRef SecTable) override; void finalize() override; @@ -384,7 +385,7 @@ Object(const object::ELFObjectFile &Obj); virtual ~Object() = default; - const SymbolTableSection *getSymTab() const { return SymbolTable; } + SymbolTableSection *getSymTab() const { return SymbolTable; } const SectionBase *getSectionHeaderStrTab() const { return SectionNames; } void removeSections(std::function ToRemove); void addSection(StringRef SecName, ArrayRef Data); Index: tools/llvm-objcopy/Object.cpp =================================================================== --- tools/llvm-objcopy/Object.cpp +++ tools/llvm-objcopy/Object.cpp @@ -175,6 +175,23 @@ Symbols.erase(Iter, std::end(Symbols)); } +void SymbolTableSection::localize( + std::function ToLocalize) { + for (const auto &Sym : Symbols) { + if (ToLocalize(*Sym)) + Sym->Binding = STB_LOCAL; + } + // Now that the local symbols aren't grouped at the start we have to reorder + // the symbols to respect this property. + std::stable_partition( + std::begin(Symbols), std::end(Symbols), + [](const SymPtr &Sym) { return Sym->Binding == STB_LOCAL; }); + // Lastly we fix the symbol indexs. + uint32_t Index = 0; + for (auto &Sym : Symbols) + Sym->Index = Index++; +} + void SymbolTableSection::initialize(SectionTableRef SecTable) { Size = 0; setStrTab(SecTable.getSectionOfType( Index: tools/llvm-objcopy/llvm-objcopy.cpp =================================================================== --- tools/llvm-objcopy/llvm-objcopy.cpp +++ tools/llvm-objcopy/llvm-objcopy.cpp @@ -117,6 +117,10 @@ "add-section", cl::desc("Make a section named
with the contents of ."), cl::value_desc("section=file")); +static cl::opt LocalizeHidden( + "localize-hidden", + cl::desc( + "Mark all symbols that have hidden or internal visibility as local")); using SectionPred = std::function; @@ -182,6 +186,14 @@ SectionPred RemovePred = [](const SectionBase &) { return false; }; + // Localize: + + if (LocalizeHidden) { + Obj->getSymTab()->localize([](const Symbol &Sym) { + return Sym.Visibility == STV_HIDDEN || Sym.Visibility == STV_INTERNAL; + }); + } + // Removes: if (!ToRemove.empty()) {