Eliminate a magic number. NFC.

[mattd]

Summary

Calculate sizeof Buffer instead of using a magic value.

[efriedma]

Please use llvm::array_lengthof to compute the length of an array.

Alternatively, there's an overload of PP.getSpelling which takes a SmallVector and returns a StringRef as a parameter; you could change this code to use it, which would remove the need for the check.

[mattd]

Thanks for the suggestion Eli. Took your initial suggestion.

[efriedma]

LGTM

[mattd]

Thanks Eli! I do not have commit permissions, so someone else will have to commit this on my behalf.

[mattd]

Ping :) I would like someone to commit this on my behalf, thanks!

lib/Frontend/PrintPreprocessedOutput.cpp

if (DropComments && Tok.is(tok::comment)) {
           reinterpret_cast<Module *>(Tok.getAnnotationValue()));
       PP.Lex(Tok);
       continue;
     } else if (IdentifierInfo *II = Tok.getIdentifierInfo()) {
       OS << II->getName();
     } else if (Tok.isLiteral() && !Tok.needsCleaning() &&
                Tok.getLiteralData()) {
       OS.write(Tok.getLiteralData(), Tok.getLength());
-    } else if (Tok.getLength() < 256) {
+    } else if (Tok.getLength() < llvm::array_lengthof(Buffer)) {
       const char *TokPtr = Buffer;
       unsigned Len = PP.getSpelling(Tok, TokPtr);
       OS.write(TokPtr, Len);
 
       // Tokens that can contain embedded newlines need to adjust our current
       // line number.
       if (Tok.getKind() == tok::comment || Tok.getKind() == tok::unknown)
         Callbacks->HandleNewlinesInToken(TokPtr, Len);