Index: lib/StaticAnalyzer/Checkers/CheckSecuritySyntaxOnly.cpp =================================================================== --- lib/StaticAnalyzer/Checkers/CheckSecuritySyntaxOnly.cpp +++ lib/StaticAnalyzer/Checkers/CheckSecuritySyntaxOnly.cpp @@ -510,6 +510,22 @@ if (!checkCall_strCommon(CE, FD)) return; + unsigned long long ArraySize = 0; + unsigned StrLen; + bool StrLenFound = false; + const auto *Target = CE->getArg(0)->IgnoreImpCasts(), + *Source = CE->getArg(1)->IgnoreImpCasts(); + if (const auto *DeclRef = dyn_cast(Target)) + if (const auto *Array = dyn_cast( + DeclRef->getDecl()->getType().getTypePtr())) + ArraySize = Array->getSize().getLimitedValue(); + if (const auto *String = dyn_cast(Source)) { + StrLen = String->getLength(); + StrLenFound = true; + } + if (StrLenFound && ArraySize >= StrLen + 1) + return; + // Issue a warning. PathDiagnosticLocation CELoc = PathDiagnosticLocation::createBegin(CE, BR.getSourceManager(), AC); Index: test/Analysis/security-syntax-checks.m =================================================================== --- test/Analysis/security-syntax-checks.m +++ test/Analysis/security-syntax-checks.m @@ -146,6 +146,11 @@ strcpy(x, y); //expected-warning{{Call to function 'strcpy' is insecure as it does not provide bounding of the memory buffer. Replace unbounded copy functions with analogous functions that support length arguments such as 'strlcpy'. CWE-119}} } +void test_strcpy_safe() { + char x[5]; + strcpy(x, "abcd"); +} + //===----------------------------------------------------------------------=== // strcat() //===----------------------------------------------------------------------===