Page MenuHomePhabricator

lldb: To allow cross-compilation of Linux/ProcessMonitor.cpp, hide PC-related stuff behind #ifdef's
ClosedPublic

Authored by pawelo on Jun 10 2014, 12:51 PM.

Details

Reviewers
tfiala
Summary

To allow cross-compilation of Linux/ProcessMonitor.cpp, hide PC-related stuff behind #ifdef's. Note that struct user used in affected code has a field named i387 which is x86-specific, therefore it should be compiled only for PC.

Diff Detail

Event Timeline

pawelo updated this revision to Diff 10296.Jun 10 2014, 12:51 PM
pawelo retitled this revision from to lldb: To allow cross-compilation of Linux/ProcessMonitor.cpp, hide PC-related stuff behind #ifdef's.
pawelo updated this object.
pawelo edited the test plan for this revision. (Show Details)
pawelo set the repository for this revision to rL LLVM.
pawelo added a subscriber: Unknown Object (MLST).
tfiala added a subscriber: tfiala.Jun 10 2014, 1:19 PM

Hey Paul,

Am I understanding you correctly that you are trying to cross compile this
for Linux on a non-Linux box?

-Todd

Looking at this now.

tfiala accepted this revision.Jun 16 2014, 7:57 AM
tfiala added a reviewer: tfiala.
This revision is now accepted and ready to land.Jun 16 2014, 7:57 AM
tfiala closed this revision.Jun 16 2014, 7:59 AM

Submitted:
Sending source/Plugins/Process/Linux/ProcessMonitor.cpp
Transmitting file data .
Committed revision 211026.

I made minor tweaks to the comment. Trying to keep with our goal of starting sentences upper cased, ending with periods, and adjusted PC reference to x86-based system.