Index: clang-tools-extra/change-namespace/tool/CMakeLists.txt =================================================================== --- clang-tools-extra/change-namespace/tool/CMakeLists.txt +++ clang-tools-extra/change-namespace/tool/CMakeLists.txt @@ -8,6 +8,7 @@ ClangChangeNamespace.cpp ) target_link_libraries(clang-change-namespace + PRIVATE clangAST clangASTMatchers clangBasic Index: clang-tools-extra/clang-apply-replacements/tool/CMakeLists.txt =================================================================== --- clang-tools-extra/clang-apply-replacements/tool/CMakeLists.txt +++ clang-tools-extra/clang-apply-replacements/tool/CMakeLists.txt @@ -6,6 +6,7 @@ ClangApplyReplacementsMain.cpp ) target_link_libraries(clang-apply-replacements + PRIVATE clangApplyReplacements clangBasic clangFormat Index: clang-tools-extra/clang-move/tool/CMakeLists.txt =================================================================== --- clang-tools-extra/clang-move/tool/CMakeLists.txt +++ clang-tools-extra/clang-move/tool/CMakeLists.txt @@ -5,6 +5,7 @@ ) target_link_libraries(clang-move + PRIVATE clangAST clangASTMatchers clangBasic Index: clang-tools-extra/clang-query/tool/CMakeLists.txt =================================================================== --- clang-tools-extra/clang-query/tool/CMakeLists.txt +++ clang-tools-extra/clang-query/tool/CMakeLists.txt @@ -2,6 +2,7 @@ add_clang_executable(clang-query ClangQuery.cpp) target_link_libraries(clang-query + PRIVATE clangAST clangASTMatchers clangBasic Index: clang-tools-extra/clang-reorder-fields/tool/CMakeLists.txt =================================================================== --- clang-tools-extra/clang-reorder-fields/tool/CMakeLists.txt +++ clang-tools-extra/clang-reorder-fields/tool/CMakeLists.txt @@ -1,6 +1,7 @@ add_clang_tool(clang-reorder-fields ClangReorderFields.cpp) target_link_libraries(clang-reorder-fields + PRIVATE clangBasic clangFrontend clangReorderFields Index: clang-tools-extra/clang-tidy/tool/CMakeLists.txt =================================================================== --- clang-tools-extra/clang-tidy/tool/CMakeLists.txt +++ clang-tools-extra/clang-tidy/tool/CMakeLists.txt @@ -12,6 +12,7 @@ clang-headers ) target_link_libraries(clang-tidy + PRIVATE clangAST clangASTMatchers clangBasic Index: clang-tools-extra/clangd/tool/CMakeLists.txt =================================================================== --- clang-tools-extra/clangd/tool/CMakeLists.txt +++ clang-tools-extra/clangd/tool/CMakeLists.txt @@ -9,6 +9,7 @@ ) target_link_libraries(clangd + PRIVATE clangBasic clangDaemon clangFormat Index: clang-tools-extra/include-fixer/find-all-symbols/tool/CMakeLists.txt =================================================================== --- clang-tools-extra/include-fixer/find-all-symbols/tool/CMakeLists.txt +++ clang-tools-extra/include-fixer/find-all-symbols/tool/CMakeLists.txt @@ -5,6 +5,7 @@ ) target_link_libraries(find-all-symbols + PRIVATE clangAST clangASTMatchers clangBasic Index: clang-tools-extra/include-fixer/tool/CMakeLists.txt =================================================================== --- clang-tools-extra/include-fixer/tool/CMakeLists.txt +++ clang-tools-extra/include-fixer/tool/CMakeLists.txt @@ -5,6 +5,7 @@ ) target_link_libraries(clang-include-fixer + PRIVATE clangBasic clangFormat clangFrontend Index: clang-tools-extra/modularize/CMakeLists.txt =================================================================== --- clang-tools-extra/modularize/CMakeLists.txt +++ clang-tools-extra/modularize/CMakeLists.txt @@ -12,6 +12,7 @@ ) target_link_libraries(modularize + PRIVATE clangAST clangBasic clangDriver Index: clang-tools-extra/pp-trace/CMakeLists.txt =================================================================== --- clang-tools-extra/pp-trace/CMakeLists.txt +++ clang-tools-extra/pp-trace/CMakeLists.txt @@ -8,6 +8,7 @@ ) target_link_libraries(pp-trace + PRIVATE clangAST clangBasic clangFrontend Index: clang-tools-extra/tool-template/CMakeLists.txt =================================================================== --- clang-tools-extra/tool-template/CMakeLists.txt +++ clang-tools-extra/tool-template/CMakeLists.txt @@ -7,6 +7,7 @@ ) target_link_libraries(tool-template + PRIVATE clangAST clangASTMatchers clangBasic Index: clang-tools-extra/unittests/change-namespace/CMakeLists.txt =================================================================== --- clang-tools-extra/unittests/change-namespace/CMakeLists.txt +++ clang-tools-extra/unittests/change-namespace/CMakeLists.txt @@ -16,6 +16,7 @@ ) target_link_libraries(ChangeNamespaceTests + PRIVATE clangAST clangASTMatchers clangBasic Index: clang-tools-extra/unittests/clang-apply-replacements/CMakeLists.txt =================================================================== --- clang-tools-extra/unittests/clang-apply-replacements/CMakeLists.txt +++ clang-tools-extra/unittests/clang-apply-replacements/CMakeLists.txt @@ -13,6 +13,7 @@ ) target_link_libraries(ClangApplyReplacementsTests + PRIVATE clangApplyReplacements clangBasic clangToolingCore Index: clang-tools-extra/unittests/clang-move/CMakeLists.txt =================================================================== --- clang-tools-extra/unittests/clang-move/CMakeLists.txt +++ clang-tools-extra/unittests/clang-move/CMakeLists.txt @@ -16,6 +16,7 @@ ) target_link_libraries(ClangMoveTests + PRIVATE clangAST clangASTMatchers clangBasic Index: clang-tools-extra/unittests/clang-query/CMakeLists.txt =================================================================== --- clang-tools-extra/unittests/clang-query/CMakeLists.txt +++ clang-tools-extra/unittests/clang-query/CMakeLists.txt @@ -12,6 +12,7 @@ ) target_link_libraries(ClangQueryTests + PRIVATE clangAST clangASTMatchers clangBasic Index: clang-tools-extra/unittests/clang-tidy/CMakeLists.txt =================================================================== --- clang-tools-extra/unittests/clang-tidy/CMakeLists.txt +++ clang-tools-extra/unittests/clang-tidy/CMakeLists.txt @@ -19,6 +19,7 @@ ReadabilityModuleTest.cpp) target_link_libraries(ClangTidyTests + PRIVATE clangAST clangASTMatchers clangBasic Index: clang-tools-extra/unittests/clangd/CMakeLists.txt =================================================================== --- clang-tools-extra/unittests/clangd/CMakeLists.txt +++ clang-tools-extra/unittests/clangd/CMakeLists.txt @@ -16,6 +16,7 @@ ) target_link_libraries(ClangdTests + PRIVATE clangBasic clangDaemon clangFormat Index: clang-tools-extra/unittests/include-fixer/CMakeLists.txt =================================================================== --- clang-tools-extra/unittests/include-fixer/CMakeLists.txt +++ clang-tools-extra/unittests/include-fixer/CMakeLists.txt @@ -17,6 +17,7 @@ ) target_link_libraries(IncludeFixerTests + PRIVATE clangBasic clangFormat clangFrontend Index: clang-tools-extra/unittests/include-fixer/find-all-symbols/CMakeLists.txt =================================================================== --- clang-tools-extra/unittests/include-fixer/find-all-symbols/CMakeLists.txt +++ clang-tools-extra/unittests/include-fixer/find-all-symbols/CMakeLists.txt @@ -13,6 +13,7 @@ ) target_link_libraries(FindAllSymbolsTests + PRIVATE clangAST clangASTMatchers clangBasic Index: clang/examples/clang-interpreter/CMakeLists.txt =================================================================== --- clang/examples/clang-interpreter/CMakeLists.txt +++ clang/examples/clang-interpreter/CMakeLists.txt @@ -17,6 +17,7 @@ ) target_link_libraries(clang-interpreter + PRIVATE clangBasic clangCodeGen clangDriver Index: clang/tools/arcmt-test/CMakeLists.txt =================================================================== --- clang/tools/arcmt-test/CMakeLists.txt +++ clang/tools/arcmt-test/CMakeLists.txt @@ -7,6 +7,7 @@ ) target_link_libraries(arcmt-test + PRIVATE clangARCMigrate clangBasic clangFrontend Index: clang/tools/c-arcmt-test/CMakeLists.txt =================================================================== --- clang/tools/c-arcmt-test/CMakeLists.txt +++ clang/tools/c-arcmt-test/CMakeLists.txt @@ -4,10 +4,12 @@ if (LLVM_BUILD_STATIC) target_link_libraries(c-arcmt-test + PRIVATE libclang_static ) else() target_link_libraries(c-arcmt-test + PRIVATE libclang ) endif() Index: clang/tools/c-index-test/CMakeLists.txt =================================================================== --- clang/tools/c-index-test/CMakeLists.txt +++ clang/tools/c-index-test/CMakeLists.txt @@ -22,6 +22,7 @@ ) else() target_link_libraries(c-index-test + PRIVATE libclang clangAST clangBasic @@ -39,7 +40,7 @@ # If libxml2 is available, make it available for c-index-test. if (CLANG_HAVE_LIBXML) include_directories(SYSTEM ${LIBXML2_INCLUDE_DIR}) - target_link_libraries(c-index-test ${LIBXML2_LIBRARIES}) + target_link_libraries(c-index-test PRIVATE ${LIBXML2_LIBRARIES}) endif() if (NOT LLVM_INSTALL_TOOLCHAIN_ONLY) Index: clang/tools/clang-check/CMakeLists.txt =================================================================== --- clang/tools/clang-check/CMakeLists.txt +++ clang/tools/clang-check/CMakeLists.txt @@ -9,6 +9,7 @@ ) target_link_libraries(clang-check + PRIVATE clangAST clangBasic clangDriver Index: clang/tools/clang-diff/CMakeLists.txt =================================================================== --- clang/tools/clang-diff/CMakeLists.txt +++ clang/tools/clang-diff/CMakeLists.txt @@ -7,6 +7,7 @@ ) target_link_libraries(clang-diff + PRIVATE clangBasic clangFrontend clangTooling Index: clang/tools/clang-format/CMakeLists.txt =================================================================== --- clang/tools/clang-format/CMakeLists.txt +++ clang/tools/clang-format/CMakeLists.txt @@ -12,6 +12,7 @@ ) target_link_libraries(clang-format + PRIVATE ${CLANG_FORMAT_LIB_DEPS} ) Index: clang/tools/clang-func-mapping/CMakeLists.txt =================================================================== --- clang/tools/clang-func-mapping/CMakeLists.txt +++ clang/tools/clang-func-mapping/CMakeLists.txt @@ -10,6 +10,7 @@ ) target_link_libraries(clang-func-mapping + PRIVATE clangAST clangBasic clangCrossTU Index: clang/tools/clang-fuzzer/CMakeLists.txt =================================================================== --- clang/tools/clang-fuzzer/CMakeLists.txt +++ clang/tools/clang-fuzzer/CMakeLists.txt @@ -66,6 +66,7 @@ ) target_link_libraries(clang-fuzzer + PRIVATE ${LLVM_LIB_FUZZING_ENGINE} clangHandleCXX ) Index: clang/tools/clang-import-test/CMakeLists.txt =================================================================== --- clang/tools/clang-import-test/CMakeLists.txt +++ clang/tools/clang-import-test/CMakeLists.txt @@ -24,5 +24,6 @@ ) target_link_libraries(clang-import-test + PRIVATE ${CLANG_IMPORT_TEST_LIB_DEPS} ) Index: clang/tools/clang-offload-bundler/CMakeLists.txt =================================================================== --- clang/tools/clang-offload-bundler/CMakeLists.txt +++ clang/tools/clang-offload-bundler/CMakeLists.txt @@ -18,6 +18,7 @@ add_dependencies(clang clang-offload-bundler) target_link_libraries(clang-offload-bundler + PRIVATE ${CLANG_OFFLOAD_BUNDLER_LIB_DEPS} ) Index: clang/tools/clang-refactor/CMakeLists.txt =================================================================== --- clang/tools/clang-refactor/CMakeLists.txt +++ clang/tools/clang-refactor/CMakeLists.txt @@ -9,6 +9,7 @@ ) target_link_libraries(clang-refactor + PRIVATE clangAST clangBasic clangFormat Index: clang/tools/clang-rename/CMakeLists.txt =================================================================== --- clang/tools/clang-rename/CMakeLists.txt +++ clang/tools/clang-rename/CMakeLists.txt @@ -6,6 +6,7 @@ add_clang_tool(clang-rename ClangRename.cpp) target_link_libraries(clang-rename + PRIVATE clangBasic clangFrontend clangRewrite Index: clang/tools/diagtool/CMakeLists.txt =================================================================== --- clang/tools/diagtool/CMakeLists.txt +++ clang/tools/diagtool/CMakeLists.txt @@ -13,6 +13,7 @@ ) target_link_libraries(diagtool + PRIVATE clangBasic clangFrontend ) Index: clang/tools/driver/CMakeLists.txt =================================================================== --- clang/tools/driver/CMakeLists.txt +++ clang/tools/driver/CMakeLists.txt @@ -38,6 +38,7 @@ ) target_link_libraries(clang + PRIVATE clangBasic clangCodeGen clangDriver @@ -85,6 +86,7 @@ set(TOOL_INFO_PLIST_OUT "${CMAKE_CURRENT_BINARY_DIR}/${TOOL_INFO_PLIST}") target_link_libraries(clang + PRIVATE "-Wl,-sectcreate,__TEXT,__info_plist,${TOOL_INFO_PLIST_OUT}") configure_file("${TOOL_INFO_PLIST}.in" "${TOOL_INFO_PLIST_OUT}" @ONLY) @@ -127,5 +129,5 @@ endif() if(WITH_POLLY AND LINK_POLLY_INTO_TOOLS) - target_link_libraries(clang Polly) + target_link_libraries(clang PRIVATE Polly) endif(WITH_POLLY AND LINK_POLLY_INTO_TOOLS) Index: clang/unittests/AST/CMakeLists.txt =================================================================== --- clang/unittests/AST/CMakeLists.txt +++ clang/unittests/AST/CMakeLists.txt @@ -21,6 +21,7 @@ ) target_link_libraries(ASTTests + PRIVATE clangAST clangASTMatchers clangBasic Index: clang/unittests/ASTMatchers/CMakeLists.txt =================================================================== --- clang/unittests/ASTMatchers/CMakeLists.txt +++ clang/unittests/ASTMatchers/CMakeLists.txt @@ -18,6 +18,7 @@ ASTMatchersTraversalTest.cpp) target_link_libraries(ASTMatchersTests + PRIVATE clangAST clangASTMatchers clangBasic Index: clang/unittests/ASTMatchers/Dynamic/CMakeLists.txt =================================================================== --- clang/unittests/ASTMatchers/Dynamic/CMakeLists.txt +++ clang/unittests/ASTMatchers/Dynamic/CMakeLists.txt @@ -8,6 +8,7 @@ RegistryTest.cpp) target_link_libraries(DynamicASTMatchersTests + PRIVATE clangAST clangASTMatchers clangBasic Index: clang/unittests/Analysis/CMakeLists.txt =================================================================== --- clang/unittests/Analysis/CMakeLists.txt +++ clang/unittests/Analysis/CMakeLists.txt @@ -8,6 +8,7 @@ ) target_link_libraries(ClangAnalysisTests + PRIVATE clangAnalysis clangAST clangASTMatchers Index: clang/unittests/Basic/CMakeLists.txt =================================================================== --- clang/unittests/Basic/CMakeLists.txt +++ clang/unittests/Basic/CMakeLists.txt @@ -12,6 +12,7 @@ ) target_link_libraries(BasicTests + PRIVATE clangBasic clangLex ) Index: clang/unittests/CodeGen/CMakeLists.txt =================================================================== --- clang/unittests/CodeGen/CMakeLists.txt +++ clang/unittests/CodeGen/CMakeLists.txt @@ -10,6 +10,7 @@ ) target_link_libraries(ClangCodeGenTests + PRIVATE clangAST clangBasic clangCodeGen Index: clang/unittests/CrossTU/CMakeLists.txt =================================================================== --- clang/unittests/CrossTU/CMakeLists.txt +++ clang/unittests/CrossTU/CMakeLists.txt @@ -8,6 +8,7 @@ ) target_link_libraries(CrossTUTests + PRIVATE clangAST clangBasic clangCrossTU Index: clang/unittests/Driver/CMakeLists.txt =================================================================== --- clang/unittests/Driver/CMakeLists.txt +++ clang/unittests/Driver/CMakeLists.txt @@ -11,6 +11,7 @@ ) target_link_libraries(ClangDriverTests + PRIVATE clangDriver clangBasic ) Index: clang/unittests/Format/CMakeLists.txt =================================================================== --- clang/unittests/Format/CMakeLists.txt +++ clang/unittests/Format/CMakeLists.txt @@ -20,6 +20,7 @@ ) target_link_libraries(FormatTests + PRIVATE clangBasic clangFormat clangFrontend Index: clang/unittests/Frontend/CMakeLists.txt =================================================================== --- clang/unittests/Frontend/CMakeLists.txt +++ clang/unittests/Frontend/CMakeLists.txt @@ -11,6 +11,7 @@ PCHPreambleTest.cpp ) target_link_libraries(FrontendTests + PRIVATE clangAST clangBasic clangFrontend Index: clang/unittests/Lex/CMakeLists.txt =================================================================== --- clang/unittests/Lex/CMakeLists.txt +++ clang/unittests/Lex/CMakeLists.txt @@ -10,6 +10,7 @@ ) target_link_libraries(LexTests + PRIVATE clangAST clangBasic clangLex Index: clang/unittests/Rename/CMakeLists.txt =================================================================== --- clang/unittests/Rename/CMakeLists.txt +++ clang/unittests/Rename/CMakeLists.txt @@ -14,6 +14,7 @@ ) target_link_libraries(ClangRenameTests + PRIVATE clangAST clangASTMatchers clangBasic Index: clang/unittests/Rewrite/CMakeLists.txt =================================================================== --- clang/unittests/Rewrite/CMakeLists.txt +++ clang/unittests/Rewrite/CMakeLists.txt @@ -6,5 +6,6 @@ RewriteBufferTest.cpp ) target_link_libraries(RewriteTests + PRIVATE clangRewrite ) Index: clang/unittests/Sema/CMakeLists.txt =================================================================== --- clang/unittests/Sema/CMakeLists.txt +++ clang/unittests/Sema/CMakeLists.txt @@ -7,6 +7,7 @@ ) target_link_libraries(SemaTests + PRIVATE clangAST clangBasic clangFrontend Index: clang/unittests/StaticAnalyzer/CMakeLists.txt =================================================================== --- clang/unittests/StaticAnalyzer/CMakeLists.txt +++ clang/unittests/StaticAnalyzer/CMakeLists.txt @@ -7,6 +7,7 @@ ) target_link_libraries(StaticAnalysisTests + PRIVATE clangBasic clangAnalysis clangStaticAnalyzerCore Index: clang/unittests/Tooling/CMakeLists.txt =================================================================== --- clang/unittests/Tooling/CMakeLists.txt +++ clang/unittests/Tooling/CMakeLists.txt @@ -35,6 +35,7 @@ ) target_link_libraries(ToolingTests + PRIVATE clangAST clangASTMatchers clangBasic Index: clang/unittests/libclang/CMakeLists.txt =================================================================== --- clang/unittests/libclang/CMakeLists.txt +++ clang/unittests/libclang/CMakeLists.txt @@ -3,5 +3,6 @@ ) target_link_libraries(libclangTests + PRIVATE libclang ) Index: lld/tools/lld/CMakeLists.txt =================================================================== --- lld/tools/lld/CMakeLists.txt +++ lld/tools/lld/CMakeLists.txt @@ -7,6 +7,7 @@ ) target_link_libraries(lld + PRIVATE lldCOFF lldDriver lldELF Index: lld/unittests/DriverTests/CMakeLists.txt =================================================================== --- lld/unittests/DriverTests/CMakeLists.txt +++ lld/unittests/DriverTests/CMakeLists.txt @@ -3,6 +3,7 @@ ) target_link_libraries(DriverTests + PRIVATE lldDriver lldMachO ) Index: lld/unittests/MachOTests/CMakeLists.txt =================================================================== --- lld/unittests/MachOTests/CMakeLists.txt +++ lld/unittests/MachOTests/CMakeLists.txt @@ -7,6 +7,7 @@ ) target_link_libraries(lldMachOTests + PRIVATE lldDriver lldMachO lldYAML Index: lldb/cmake/modules/AddLLDB.cmake =================================================================== --- lldb/cmake/modules/AddLLDB.cmake +++ lldb/cmake/modules/AddLLDB.cmake @@ -92,7 +92,7 @@ list(APPEND LLVM_LINK_COMPONENTS ${ARG_LINK_COMPONENTS}) add_llvm_executable(${name} ${ARG_UNPARSED_ARGUMENTS}) - target_link_libraries(${name} ${ARG_LINK_LIBS}) + target_link_libraries(${name} PRIVATE ${ARG_LINK_LIBS}) set_target_properties(${name} PROPERTIES FOLDER "lldb executables") Index: lldb/unittests/CMakeLists.txt =================================================================== --- lldb/unittests/CMakeLists.txt +++ lldb/unittests/CMakeLists.txt @@ -44,7 +44,7 @@ POST_BUILD COMMAND "${CMAKE_COMMAND}" -E make_directory ${CMAKE_CURRENT_BINARY_DIR}/Inputs) - target_link_libraries(${test_name} ${ARG_LINK_LIBS}) + target_link_libraries(${test_name} PRIVATE ${ARG_LINK_LIBS}) endfunction() function(add_unittest_inputs test_name inputs) Index: lldb/unittests/Interpreter/CMakeLists.txt =================================================================== --- lldb/unittests/Interpreter/CMakeLists.txt +++ lldb/unittests/Interpreter/CMakeLists.txt @@ -8,5 +8,6 @@ ) target_link_libraries(InterpreterTests + PRIVATE ${PYTHON_LIBRARY} ) Index: llvm/cmake/modules/AddLLVM.cmake =================================================================== --- llvm/cmake/modules/AddLLVM.cmake +++ llvm/cmake/modules/AddLLVM.cmake @@ -768,7 +768,7 @@ # libpthreads overrides some standard library symbols, so main # executable must be linked with it in order to provide consistent # API for all shared libaries loaded by this executable. - target_link_libraries(${name} ${LLVM_PTHREAD_LIB}) + target_link_libraries(${name} PRIVATE ${LLVM_PTHREAD_LIB}) endif() endmacro(add_llvm_executable name) @@ -1093,7 +1093,7 @@ # libpthreads overrides some standard library symbols, so main # executable must be linked with it in order to provide consistent # API for all shared libaries loaded by this executable. - target_link_libraries(${test_name} gtest_main gtest ${LLVM_PTHREAD_LIB}) + target_link_libraries(${test_name} PRIVATE gtest_main gtest ${LLVM_PTHREAD_LIB}) add_dependencies(${test_suite} ${test_name}) get_target_property(test_suite_folder ${test_suite} FOLDER) Index: llvm/cmake/modules/LLVM-Config.cmake =================================================================== --- llvm/cmake/modules/LLVM-Config.cmake +++ llvm/cmake/modules/LLVM-Config.cmake @@ -87,7 +87,7 @@ endif() endif() - target_link_libraries(${executable} LLVM) + target_link_libraries(${executable} PRIVATE LLVM) endif() explicit_llvm_config(${executable} ${link_components}) @@ -101,7 +101,7 @@ get_target_property(t ${executable} TYPE) if(t STREQUAL "STATIC_LIBRARY") target_link_libraries(${executable} INTERFACE ${LIBRARIES}) - elseif(t STREQUAL "SHARED_LIBRARY" OR t STREQUAL "MODULE_LIBRARY") + elseif(t STREQUAL "EXECUTABLE" OR t STREQUAL "SHARED_LIBRARY" OR t STREQUAL "MODULE_LIBRARY") target_link_libraries(${executable} PRIVATE ${LIBRARIES}) else() # Use plain form for legacy user. Index: llvm/examples/ParallelJIT/CMakeLists.txt =================================================================== --- llvm/examples/ParallelJIT/CMakeLists.txt +++ llvm/examples/ParallelJIT/CMakeLists.txt @@ -11,4 +11,4 @@ ParallelJIT.cpp ) -target_link_libraries(ParallelJIT ${LLVM_PTHREAD_LIB}) +target_link_libraries(ParallelJIT PRIVATE ${LLVM_PTHREAD_LIB}) Index: llvm/tools/bugpoint/CMakeLists.txt =================================================================== --- llvm/tools/bugpoint/CMakeLists.txt +++ llvm/tools/bugpoint/CMakeLists.txt @@ -37,7 +37,7 @@ export_executable_symbols(bugpoint) if(WITH_POLLY AND LINK_POLLY_INTO_TOOLS) - target_link_libraries(bugpoint Polly) + target_link_libraries(bugpoint PRIVATE Polly) # Ensure LLVMTarget can resolve dependences in Polly. - target_link_libraries(bugpoint LLVMTarget) + target_link_libraries(bugpoint PRIVATE LLVMTarget) endif(WITH_POLLY AND LINK_POLLY_INTO_TOOLS) Index: llvm/tools/dsymutil/CMakeLists.txt =================================================================== --- llvm/tools/dsymutil/CMakeLists.txt +++ llvm/tools/dsymutil/CMakeLists.txt @@ -22,5 +22,5 @@ ) IF(APPLE) - target_link_libraries(llvm-dsymutil "-framework CoreFoundation") + target_link_libraries(llvm-dsymutil PRIVATE "-framework CoreFoundation") ENDIF(APPLE) Index: llvm/tools/llvm-cfi-verify/CMakeLists.txt =================================================================== --- llvm/tools/llvm-cfi-verify/CMakeLists.txt +++ llvm/tools/llvm-cfi-verify/CMakeLists.txt @@ -15,4 +15,4 @@ llvm-cfi-verify.cpp) add_subdirectory(lib) -target_link_libraries(llvm-cfi-verify LLVMCFIVerify) +target_link_libraries(llvm-cfi-verify PRIVATE LLVMCFIVerify) Index: llvm/tools/llvm-objdump/CMakeLists.txt =================================================================== --- llvm/tools/llvm-objdump/CMakeLists.txt +++ llvm/tools/llvm-objdump/CMakeLists.txt @@ -23,7 +23,7 @@ ) if(HAVE_LIBXAR) - target_link_libraries(llvm-objdump ${XAR_LIB}) + target_link_libraries(llvm-objdump PRIVATE ${XAR_LIB}) endif() if(LLVM_INSTALL_BINUTILS_SYMLINKS) Index: llvm/tools/opt/CMakeLists.txt =================================================================== --- llvm/tools/opt/CMakeLists.txt +++ llvm/tools/opt/CMakeLists.txt @@ -37,5 +37,5 @@ export_executable_symbols(opt) if(WITH_POLLY AND LINK_POLLY_INTO_TOOLS) - target_link_libraries(opt Polly) + target_link_libraries(opt PRIVATE Polly) endif(WITH_POLLY AND LINK_POLLY_INTO_TOOLS) Index: llvm/unittests/DebugInfo/CodeView/CMakeLists.txt =================================================================== --- llvm/unittests/DebugInfo/CodeView/CMakeLists.txt +++ llvm/unittests/DebugInfo/CodeView/CMakeLists.txt @@ -11,4 +11,4 @@ ${DebugInfoCodeViewSources} ) -target_link_libraries(DebugInfoCodeViewTests LLVMTestingSupport) \ No newline at end of file +target_link_libraries(DebugInfoCodeViewTests PRIVATE LLVMTestingSupport) Index: llvm/unittests/DebugInfo/DWARF/CMakeLists.txt =================================================================== --- llvm/unittests/DebugInfo/DWARF/CMakeLists.txt +++ llvm/unittests/DebugInfo/DWARF/CMakeLists.txt @@ -18,4 +18,4 @@ ${DebugInfoSources} ) -target_link_libraries(DebugInfoDWARFTests LLVMTestingSupport) +target_link_libraries(DebugInfoDWARFTests PRIVATE LLVMTestingSupport) Index: llvm/unittests/DebugInfo/MSF/CMakeLists.txt =================================================================== --- llvm/unittests/DebugInfo/MSF/CMakeLists.txt +++ llvm/unittests/DebugInfo/MSF/CMakeLists.txt @@ -12,4 +12,4 @@ ${DebugInfoMSFSources} ) -target_link_libraries(DebugInfoMSFTests LLVMTestingSupport) +target_link_libraries(DebugInfoMSFTests PRIVATE LLVMTestingSupport) Index: llvm/unittests/DebugInfo/PDB/CMakeLists.txt =================================================================== --- llvm/unittests/DebugInfo/PDB/CMakeLists.txt +++ llvm/unittests/DebugInfo/PDB/CMakeLists.txt @@ -14,4 +14,4 @@ ${DebugInfoPDBSources} ) -target_link_libraries(DebugInfoPDBTests LLVMTestingSupport) +target_link_libraries(DebugInfoPDBTests PRIVATE LLVMTestingSupport) Index: llvm/unittests/ExecutionEngine/Orc/CMakeLists.txt =================================================================== --- llvm/unittests/ExecutionEngine/Orc/CMakeLists.txt +++ llvm/unittests/ExecutionEngine/Orc/CMakeLists.txt @@ -23,4 +23,4 @@ RTDyldObjectLinkingLayerTest.cpp ) -target_link_libraries(OrcJITTests ${LLVM_PTHREAD_LIB}) +target_link_libraries(OrcJITTests PRIVATE ${LLVM_PTHREAD_LIB}) Index: llvm/unittests/ProfileData/CMakeLists.txt =================================================================== --- llvm/unittests/ProfileData/CMakeLists.txt +++ llvm/unittests/ProfileData/CMakeLists.txt @@ -11,4 +11,4 @@ SampleProfTest.cpp ) -target_link_libraries(ProfileDataTests LLVMTestingSupport) +target_link_libraries(ProfileDataTests PRIVATE LLVMTestingSupport) Index: llvm/unittests/Support/CMakeLists.txt =================================================================== --- llvm/unittests/Support/CMakeLists.txt +++ llvm/unittests/Support/CMakeLists.txt @@ -74,6 +74,6 @@ set_source_files_properties(AlignOfTest.cpp PROPERTIES COMPILE_FLAGS -w) # ManagedStatic.cpp uses . -target_link_libraries(SupportTests LLVMTestingSupport ${LLVM_PTHREAD_LIB}) +target_link_libraries(SupportTests PRIVATE LLVMTestingSupport ${LLVM_PTHREAD_LIB}) add_subdirectory(DynamicLibrary) Index: llvm/unittests/Support/DynamicLibrary/CMakeLists.txt =================================================================== --- llvm/unittests/Support/DynamicLibrary/CMakeLists.txt +++ llvm/unittests/Support/DynamicLibrary/CMakeLists.txt @@ -4,7 +4,7 @@ set_target_properties(DynamicLibraryLib PROPERTIES FOLDER "Tests") add_llvm_unittest(DynamicLibraryTests DynamicLibraryTest.cpp) -target_link_libraries(DynamicLibraryTests DynamicLibraryLib) +target_link_libraries(DynamicLibraryTests PRIVATE DynamicLibraryLib) export_executable_symbols(DynamicLibraryTests) function(dynlib_add_module NAME) Index: llvm/unittests/tools/llvm-cfi-verify/CMakeLists.txt =================================================================== --- llvm/unittests/tools/llvm-cfi-verify/CMakeLists.txt +++ llvm/unittests/tools/llvm-cfi-verify/CMakeLists.txt @@ -14,4 +14,4 @@ add_llvm_unittest(CFIVerifyTests FileAnalysis.cpp GraphBuilder.cpp) -target_link_libraries(CFIVerifyTests LLVMCFIVerify) +target_link_libraries(CFIVerifyTests PRIVATE LLVMCFIVerify) Index: llvm/utils/FileCheck/CMakeLists.txt =================================================================== --- llvm/utils/FileCheck/CMakeLists.txt +++ llvm/utils/FileCheck/CMakeLists.txt @@ -2,4 +2,4 @@ FileCheck.cpp ) -target_link_libraries(FileCheck LLVMSupport) +target_link_libraries(FileCheck PRIVATE LLVMSupport) Index: llvm/utils/not/CMakeLists.txt =================================================================== --- llvm/utils/not/CMakeLists.txt +++ llvm/utils/not/CMakeLists.txt @@ -2,4 +2,4 @@ not.cpp ) -target_link_libraries(not LLVMSupport) +target_link_libraries(not PRIVATE LLVMSupport) Index: llvm/utils/yaml-bench/CMakeLists.txt =================================================================== --- llvm/utils/yaml-bench/CMakeLists.txt +++ llvm/utils/yaml-bench/CMakeLists.txt @@ -2,4 +2,4 @@ YAMLBench.cpp ) -target_link_libraries(yaml-bench LLVMSupport) +target_link_libraries(yaml-bench PRIVATE LLVMSupport) Index: polly/unittests/CMakeLists.txt =================================================================== --- polly/unittests/CMakeLists.txt +++ polly/unittests/CMakeLists.txt @@ -11,12 +11,12 @@ add_executable(${test_name} EXCLUDE_FROM_ALL ${ARGN}) set_target_properties(${test_name} PROPERTIES RUNTIME_OUTPUT_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}) - target_link_libraries(${test_name} gtest_main gtest) + target_link_libraries(${test_name} PRIVATE gtest_main gtest) add_dependencies(PollyUnitTests ${test_name}) set_property(TARGET ${test_name} PROPERTY FOLDER "Polly") endif() - target_link_libraries(${test_name} Polly) + target_link_libraries(${test_name} PRIVATE Polly) endfunction() add_subdirectory(Isl)