Index: lld/trunk/ELF/LinkerScript.cpp =================================================================== --- lld/trunk/ELF/LinkerScript.cpp +++ lld/trunk/ELF/LinkerScript.cpp @@ -533,7 +533,7 @@ if (!S->Live || S->Parent) continue; - StringRef Name = getOutputSectionName(S->Name); + StringRef Name = getOutputSectionName(S); if (Config->OrphanHandling == OrphanHandlingPolicy::Error) error(toString(S) + " is being placed in '" + Name + "'"); Index: lld/trunk/ELF/SyntheticSections.cpp =================================================================== --- lld/trunk/ELF/SyntheticSections.cpp +++ lld/trunk/ELF/SyntheticSections.cpp @@ -2517,7 +2517,7 @@ if (!MS->Live) continue; - StringRef OutsecName = getOutputSectionName(MS->Name); + StringRef OutsecName = getOutputSectionName(MS); uint32_t Alignment = std::max(MS->Alignment, MS->Entsize); auto I = llvm::find_if(MergeSections, [=](MergeSyntheticSection *Sec) { Index: lld/trunk/ELF/Writer.h =================================================================== --- lld/trunk/ELF/Writer.h +++ lld/trunk/ELF/Writer.h @@ -46,7 +46,7 @@ bool HasLMA = false; }; -llvm::StringRef getOutputSectionName(llvm::StringRef Name); +llvm::StringRef getOutputSectionName(InputSectionBase *S); template uint32_t calcMipsEFlags(); Index: lld/trunk/ELF/Writer.cpp =================================================================== --- lld/trunk/ELF/Writer.cpp +++ lld/trunk/ELF/Writer.cpp @@ -87,7 +87,9 @@ }; } // anonymous namespace -StringRef elf::getOutputSectionName(StringRef Name) { +StringRef elf::getOutputSectionName(InputSectionBase *S) { + StringRef Name = S->Name; + // ".zdebug_" is a prefix for ZLIB-compressed sections. // Because we decompressed input sections, we want to remove 'z'. if (Name.startswith(".zdebug_")) @@ -96,13 +98,17 @@ if (Config->Relocatable) return Name; - // This is for --emit-relocs. If .text.foo is emitted as .text, we want to - // emit .rela.text.foo as .rel.text for consistency (this is not technically - // required, but not doing it is odd). This code guarantees that. - if (Name.startswith(".rel.")) - return Saver.save(".rel" + getOutputSectionName(Name.substr(4))); - if (Name.startswith(".rela.")) - return Saver.save(".rela" + getOutputSectionName(Name.substr(5))); + // This is for --emit-relocs. If .text.foo is emitted as .text.bar, we want + // to emit .rela.text.foo as .rela.text.bar for consistency (this is not + // technically required, but not doing it is odd). This code guarantees that. + if ((S->Type == SHT_REL || S->Type == SHT_RELA) && + !isa(S)) { + OutputSection *Out = + cast(S)->getRelocatedSection()->getOutputSection(); + if (S->Type == SHT_RELA) + return Saver.save(".rela" + Out->Name); + return Saver.save(".rel" + Out->Name); + } for (StringRef V : {".text.", ".rodata.", ".data.rel.ro.", ".data.", ".bss.rel.ro.", Index: lld/trunk/test/ELF/linkerscript/emit-reloc-section-names.s =================================================================== --- lld/trunk/test/ELF/linkerscript/emit-reloc-section-names.s +++ lld/trunk/test/ELF/linkerscript/emit-reloc-section-names.s @@ -0,0 +1,22 @@ +# REQUIRES: x86 +# RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %s -o %t.o +# RUN: echo "SECTIONS { .text.zed : { *(.text.foo) } \ +# RUN: .text.qux : { *(.text.bar) } }" > %t.script +# RUN: ld.lld -T %t.script --emit-relocs %t.o -o %t +# RUN: llvm-objdump -section-headers %t | FileCheck %s + +## Check we name relocation sections in according to +## their target sections names. + +# CHECK: .text.zed +# CHECK: .text.qux +# CHECK: .rela.text.zed +# CHECK: .rela.text.qux + +.section .text.foo,"ax" +foo: + mov $bar, %rax + +.section .text.bar,"ax" +bar: + mov $foo, %rax Index: lld/trunk/test/ELF/linkerscript/emit-relocs-multiple.s =================================================================== --- lld/trunk/test/ELF/linkerscript/emit-relocs-multiple.s +++ lld/trunk/test/ELF/linkerscript/emit-relocs-multiple.s @@ -5,7 +5,7 @@ # RUN: llvm-readobj -r %t1 | FileCheck %s # CHECK: Relocations [ -# CHECK-NEXT: Section {{.*}} .rela.foo { +# CHECK-NEXT: Section {{.*}} .rela.zed { # CHECK-NEXT: 0x1 R_X86_64_32 .zed 0x0 # CHECK-NEXT: 0x6 R_X86_64_32 .zed 0x5 # CHECK-NEXT: }