Index: lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp =================================================================== --- lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp +++ lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp @@ -535,6 +535,10 @@ SMLoc getEndLoc() const override { return EndLoc; } + + SMRange getLocRange() const { + return SMRange(StartLoc, EndLoc); + } Modifiers getModifiers() const { assert(isRegKind() || isImmTy(ImmTyNone)); @@ -2244,6 +2248,9 @@ return true; } +static std::string AMDGPUMnemonicSpellCheck(StringRef S, uint64_t FBS, + unsigned VariantID = 0); + bool AMDGPUAsmParser::MatchAndEmitInstruction(SMLoc IDLoc, unsigned &Opcode, OperandVector &Operands, MCStreamer &Out, @@ -2286,8 +2293,13 @@ case Match_MissingFeature: return Error(IDLoc, "instruction not supported on this GPU"); - case Match_MnemonicFail: - return Error(IDLoc, "unrecognized instruction mnemonic"); + case Match_MnemonicFail: { + uint64_t FBS = ComputeAvailableFeatures(getSTI().getFeatureBits()); + std::string Suggestion = AMDGPUMnemonicSpellCheck( + ((AMDGPUOperand &)*Operands[0]).getToken(), FBS); + return Error(IDLoc, "invalid instruction" + Suggestion, + ((AMDGPUOperand &)*Operands[0]).getLocRange()); + } case Match_InvalidOperand: { SMLoc ErrorLoc = IDLoc; @@ -4767,6 +4779,7 @@ #define GET_REGISTER_MATCHER #define GET_MATCHER_IMPLEMENTATION +#define GET_MNEMONIC_SPELL_CHECKER #include "AMDGPUGenAsmMatcher.inc" // This fuction should be defined after auto-generated include so that we have Index: test/MC/AMDGPU/invalid-instructions-spellcheck.s =================================================================== --- /dev/null +++ test/MC/AMDGPU/invalid-instructions-spellcheck.s @@ -0,0 +1,48 @@ +# RUN: not llvm-mc -triple amdgcn < %s 2>&1 | FileCheck %s + +# This tests the mnemonic spell checker. + +# First check what happens when an instruction is omitted: + +v2, v4, v6 + +# CHECK: unknown token in expression +# CHECK-NEXT: v2, v4, v6 +# CHECK-NEXT: ^ + +# CHECK: error: not a valid operand. +# CHECK-NEXT: v2, v4, v6 +# CHECK-NEXT: ^ + +# We don't want to see a suggestion here; the edit distance is too large to +# give sensible suggestions: + +aaaaaaaaaaaaaaa v1, v2, v3 + +# CHECK: error: invalid instruction +# CHECK-NEXT: aaaaaaaaaaaaaaa v1, v2, v3 +# CHECK-NEXT: ^ + +# Check that we get one suggestion: 'dsc_write_src2_b64' is 1 edit away, i.e. an deletion. + +dsc_write_src2_b64 v1, v2, v3 + +# CHECK: error: invalid instruction, did you mean: ds_write_src2_b64? +# CHECK-NEXT: dsc_write_src2_b64 v1, v2, v3 +# CHECK-NEXT: ^ + +# Check edit distance 1 and 2, just insertions: + +s_mov_b v1, v2 + +# CHECK: error: invalid instruction, did you mean: s_mov_b32, s_mov_b64? +# CHECK-NEXT: s_mov_b v1, v2 +# CHECK-NEXT: ^ + +# Check an instruction that is 2 edits away, and also has a lot of candidates: + +s_load_dwordx v1, v2, v3 + +# CHECK: error: invalid instruction, did you mean: s_load_dword, s_load_dwordx16, s_load_dwordx2, s_load_dwordx4, s_load_dwordx8? +# CHECK-NEXT: s_load_dwordx v1, v2, v3 +# CHECK-NEXT: ^