Page MenuHomePhabricator

[OMPT] Use frames at different level when using clang version 5 or higher with debug flag
ClosedPublic

Authored by sconvent on Nov 29 2017, 3:09 AM.

Event Timeline

sconvent created this revision.Nov 29 2017, 3:09 AM
Hahnfeld edited edge metadata.Nov 29 2017, 6:26 AM

(note: please post full context information as described in https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface)

runtime/test/ompt/callback.h
74

I propose to always issue this warning: The test will also fail if the user specifies -DDEBUG without -g. In normal testing with lit, this won't do any harm because stderr is filtered away if the test is successful.

Just had a more thorough look at the tests which include all kinds of outlined functions. I previously suggested print_frame_in_task() because I thought Clang would only wrap the function for tasks. Maybe print_frame_from_outlined_fn() would be a better name after all?

runtime/test/ompt/parallel/nested.c
28–29

This should use the new macro

sconvent updated this revision to Diff 126707.Dec 13 2017, 2:45 AM

Implemented all suggestions.

This revision is now accepted and ready to land.Dec 13 2017, 5:59 AM
This revision was automatically updated to reflect the committed changes.