Index: clang-tools-extra/trunk/clang-tidy/objc/AvoidNSErrorInitCheck.h =================================================================== --- clang-tools-extra/trunk/clang-tidy/objc/AvoidNSErrorInitCheck.h +++ clang-tools-extra/trunk/clang-tidy/objc/AvoidNSErrorInitCheck.h @@ -0,0 +1,36 @@ +//===--- AvoidNSErrorInitCheck.h - clang-tidy--------------------*- C++ -*-===// +// +// The LLVM Compiler Infrastructure +// +// This file is distributed under the University of Illinois Open Source +// License. See LICENSE.TXT for details. +// +//===----------------------------------------------------------------------===// + +#ifndef LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_OBJC_AVOIDNSERRORINITCHECK_H +#define LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_OBJC_AVOIDNSERRORINITCHECK_H + +#include "../ClangTidy.h" + +namespace clang { +namespace tidy { +namespace objc { + +/// Finds usages of [NSSError init]. It is not the proper way of creating +/// NSError. errorWithDomain:code:userInfo: should be used instead. +/// +/// For the user-facing documentation see: +/// http://clang.llvm.org/extra/clang-tidy/checks/objc-avoid-nserror-init.html +class AvoidNSErrorInitCheck : public ClangTidyCheck { + public: + AvoidNSErrorInitCheck(StringRef Name, ClangTidyContext *Context) + : ClangTidyCheck(Name, Context) {} + void registerMatchers(ast_matchers::MatchFinder *Finder) override; + void check(const ast_matchers::MatchFinder::MatchResult &Result) override; +}; + +} // namespace objc +} // namespace tidy +} // namespace clang + +#endif // LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_OBJC_AVOIDNSERRORINITCHECK_H Index: clang-tools-extra/trunk/clang-tidy/objc/AvoidNSErrorInitCheck.cpp =================================================================== --- clang-tools-extra/trunk/clang-tidy/objc/AvoidNSErrorInitCheck.cpp +++ clang-tools-extra/trunk/clang-tidy/objc/AvoidNSErrorInitCheck.cpp @@ -0,0 +1,37 @@ +//===--- AvoidNSErrorInitCheck.cpp - clang-tidy----------------------------===// +// +// The LLVM Compiler Infrastructure +// +// This file is distributed under the University of Illinois Open Source +// License. See LICENSE.TXT for details. +// +//===----------------------------------------------------------------------===// + +#include "AvoidNSErrorInitCheck.h" +#include "clang/AST/ASTContext.h" +#include "clang/ASTMatchers/ASTMatchFinder.h" + +using namespace clang::ast_matchers; + +namespace clang { +namespace tidy { +namespace objc { + +void AvoidNSErrorInitCheck::registerMatchers(MatchFinder *Finder) { + Finder->addMatcher(objcMessageExpr(hasSelector("init"), + hasReceiverType(asString("NSError *"))) + .bind("nserrorInit"), + this); +} + +void AvoidNSErrorInitCheck::check(const MatchFinder::MatchResult &Result) { + const auto *MatchedExpr = + Result.Nodes.getNodeAs("nserrorInit"); + diag(MatchedExpr->getLocStart(), + "use errorWithDomain:code:userInfo: or initWithDomain:code:userInfo: to " + "create a new NSError"); +} + +} // namespace objc +} // namespace tidy +} // namespace clang Index: clang-tools-extra/trunk/clang-tidy/objc/AvoidNserrorInitCheck.h =================================================================== --- clang-tools-extra/trunk/clang-tidy/objc/AvoidNserrorInitCheck.h +++ clang-tools-extra/trunk/clang-tidy/objc/AvoidNserrorInitCheck.h @@ -1,36 +0,0 @@ -//===--- AvoidNSErrorInitCheck.h - clang-tidy--------------------*- C++ -*-===// -// -// The LLVM Compiler Infrastructure -// -// This file is distributed under the University of Illinois Open Source -// License. See LICENSE.TXT for details. -// -//===----------------------------------------------------------------------===// - -#ifndef LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_OBJC_AVOIDNSERRORINITCHECK_H -#define LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_OBJC_AVOIDNSERRORINITCHECK_H - -#include "../ClangTidy.h" - -namespace clang { -namespace tidy { -namespace objc { - -/// Finds usages of [NSSError init]. It is not the proper way of creating -/// NSError. errorWithDomain:code:userInfo: should be used instead. -/// -/// For the user-facing documentation see: -/// http://clang.llvm.org/extra/clang-tidy/checks/objc-avoid-nserror-init.html -class AvoidNSErrorInitCheck : public ClangTidyCheck { - public: - AvoidNSErrorInitCheck(StringRef Name, ClangTidyContext *Context) - : ClangTidyCheck(Name, Context) {} - void registerMatchers(ast_matchers::MatchFinder *Finder) override; - void check(const ast_matchers::MatchFinder::MatchResult &Result) override; -}; - -} // namespace objc -} // namespace tidy -} // namespace clang - -#endif // LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_OBJC_AVOIDNSERRORINITCHECK_H Index: clang-tools-extra/trunk/clang-tidy/objc/AvoidNserrorInitCheck.cpp =================================================================== --- clang-tools-extra/trunk/clang-tidy/objc/AvoidNserrorInitCheck.cpp +++ clang-tools-extra/trunk/clang-tidy/objc/AvoidNserrorInitCheck.cpp @@ -1,37 +0,0 @@ -//===--- AvoidNSErrorInitCheck.cpp - clang-tidy----------------------------===// -// -// The LLVM Compiler Infrastructure -// -// This file is distributed under the University of Illinois Open Source -// License. See LICENSE.TXT for details. -// -//===----------------------------------------------------------------------===// - -#include "AvoidNSErrorInitCheck.h" -#include "clang/AST/ASTContext.h" -#include "clang/ASTMatchers/ASTMatchFinder.h" - -using namespace clang::ast_matchers; - -namespace clang { -namespace tidy { -namespace objc { - -void AvoidNSErrorInitCheck::registerMatchers(MatchFinder *Finder) { - Finder->addMatcher(objcMessageExpr(hasSelector("init"), - hasReceiverType(asString("NSError *"))) - .bind("nserrorInit"), - this); -} - -void AvoidNSErrorInitCheck::check(const MatchFinder::MatchResult &Result) { - const auto *MatchedExpr = - Result.Nodes.getNodeAs("nserrorInit"); - diag(MatchedExpr->getLocStart(), - "use errorWithDomain:code:userInfo: or initWithDomain:code:userInfo: to " - "create a new NSError"); -} - -} // namespace objc -} // namespace tidy -} // namespace clang Index: clang-tools-extra/trunk/docs/ReleaseNotes.rst =================================================================== --- clang-tools-extra/trunk/docs/ReleaseNotes.rst +++ clang-tools-extra/trunk/docs/ReleaseNotes.rst @@ -57,6 +57,11 @@ Improvements to clang-tidy -------------------------- +- New `objc-avoid-nserror-init + `_ check + + Add new check to detect the use of [NSError init]. + - New module `fuchsia` for Fuchsia style checks. - New module `objc` for Objective-C style checks.