Page MenuHomePhabricator

Add comments to DWARFCompileUnit length fields/methods
ClosedPublic

Authored by jankratochvil on Nov 18 2017, 12:48 PM.

Details

Summary

All the methods have similar names and they return different lengths, document it.

Is such patch obvious enough to check it in without an approval?

Event Timeline

jankratochvil created this revision.Nov 18 2017, 12:48 PM
labath accepted this revision.Nov 19 2017, 1:56 AM
labath added a subscriber: lldb-commits.

If you are confident that the behavior you are documenting is correct, I think you can submit patches like these without approval. If you do end up sending something up for review, please be sure to add "lldb-commits" as a subscriber.

This revision is now accepted and ready to land.Nov 19 2017, 1:56 AM
This revision was automatically updated to reflect the committed changes.