Index: include/__config =================================================================== --- include/__config +++ include/__config @@ -76,9 +76,11 @@ // its vtable and typeinfo to libc++ rather than having all other libraries // using that class define their own copies. #define _LIBCPP_ABI_BAD_FUNCTION_CALL_KEY_FUNCTION - // Enable optimized version of __do_get_(un)signed which avoids redundant copies. #define _LIBCPP_ABI_OPTIMIZED_LOCALE_NUM_GET +// Use the smallest possible integer type to represent the index of the variant. +// Previously libc++ used "unsigned int" exclusivly. +#define _LIBCPP_ABI_VARIANT_INDEX_TYPE_OPTIMIZATION #elif _LIBCPP_ABI_VERSION == 1 #if !defined(_LIBCPP_OBJECT_FORMAT_COFF) // Enable compiling copies of now inline methods into the dylib to support Index: include/variant =================================================================== --- include/variant +++ include/variant @@ -207,6 +207,7 @@ #include #include #include +#include #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER) #pragma GCC system_header @@ -283,7 +284,28 @@ }; constexpr size_t variant_npos = static_cast(-1); -constexpr unsigned int __variant_npos = static_cast(-1); + +constexpr int __choose_index_type(unsigned int __num_elem) { + if (__num_elem < std::numeric_limits::max()) + return 0; + if (__num_elem < std::numeric_limits::max()) + return 1; + return 2; +} + +template +using __variant_index_t = +#ifndef _LIBCPP_ABI_VARIANT_INDEX_TYPE_OPTIMIZATION + unsigned int; +#else + std::tuple_element_t< + __choose_index_type(_NumAlts), + std::tuple + >; +#endif + +template +constexpr _IndexType __variant_npos = static_cast<_IndexType>(-1); namespace __find_detail { @@ -647,9 +669,11 @@ template <_Trait _DestructibleTrait, class... _Types> class _LIBCPP_TEMPLATE_VIS __base { public: + using __index_t = __variant_index_t; + inline _LIBCPP_INLINE_VISIBILITY explicit constexpr __base(__valueless_t tag) noexcept - : __data(tag), __index(__variant_npos) {} + : __data(tag), __index(__variant_npos<__index_t>) {} template inline _LIBCPP_INLINE_VISIBILITY @@ -665,7 +689,7 @@ inline _LIBCPP_INLINE_VISIBILITY constexpr size_t index() const noexcept { - return __index == __variant_npos ? variant_npos : __index; + return __index == __variant_npos<__index_t> ? variant_npos : __index; } protected: @@ -685,7 +709,7 @@ static constexpr size_t __size() { return sizeof...(_Types); } __union<_DestructibleTrait, 0, _Types...> __data; - unsigned int __index; + __index_t __index; friend struct __access::__base; friend struct __visitation::__base; @@ -696,10 +720,11 @@ #define _LIBCPP_VARIANT_DESTRUCTOR(destructible_trait, destructor, destroy) \ template \ - class _LIBCPP_TEMPLATE_VIS __destructor<__traits<_Types...>, \ + class _LIBCPP_TEMPLATE_VIS __destructor<__traits<_Types...>, \ destructible_trait> \ : public __base { \ using __base_type = __base; \ + using __index_t = typename __base_type::__index_t; \ \ public: \ using __base_type::__base_type; \ @@ -719,7 +744,7 @@ _LIBCPP_VARIANT_DESTRUCTOR( _Trait::_TriviallyAvailable, ~__destructor() = default;, - void __destroy() noexcept { this->__index = __variant_npos; }); + void __destroy() noexcept { this->__index = __variant_npos<__index_t>; }); _LIBCPP_VARIANT_DESTRUCTOR( _Trait::_Available, @@ -733,7 +758,7 @@ }, *this); } - this->__index = __variant_npos; + this->__index = __variant_npos<__index_t>; }); _LIBCPP_VARIANT_DESTRUCTOR( Index: test/libcxx/utilities/variant/variant.variant/variant_size.pass.cpp =================================================================== --- /dev/null +++ test/libcxx/utilities/variant/variant.variant/variant_size.pass.cpp @@ -0,0 +1,68 @@ +// -*- C++ -*- +//===----------------------------------------------------------------------===// +// +// The LLVM Compiler Infrastructure +// +// This file is dual licensed under the MIT and the University of Illinois Open +// Source Licenses. See LICENSE.TXT for details. +// +//===----------------------------------------------------------------------===// + +// UNSUPPORTED: c++98, c++03, c++11, c++14 + +// + +// template class variant; + +#include +#include +#include +#include + +template +struct make_variant_imp; + +template +struct make_variant_imp> { + using type = std::variant; +}; + +template +using make_variant_t = typename make_variant_imp>::type; + +constexpr bool ExpectEqual = +#ifdef _LIBCPP_ABI_VARIANT_INDEX_TYPE_OPTIMIZATION + false; +#else + true; +#endif + +template +void test_index_type() { + using Lim = std::numeric_limits; + using T1 = make_variant_t; + using T2 = make_variant_t; + static_assert((sizeof(T1) == sizeof(T2)) == ExpectEqual, ""); +} + +template +void test_index_internals() { + using Lim = std::numeric_limits; + static_assert(std::__choose_index_type(Lim::max() -1) != + std::__choose_index_type(Lim::max()), ""); + static_assert(std::is_same_v< + std::__variant_index_t, + std::__variant_index_t + > == ExpectEqual, ""); + using IndexT = std::__variant_index_t; + using IndexLim = std::numeric_limits; + static_assert(std::__variant_npos == IndexLim::max(), ""); +} + +int main() { + test_index_type(); + // This won't compile due to template depth issues. + //test_index_type(); + test_index_internals(); + test_index_internals(); +}