Page MenuHomePhabricator

Downgrade "definition of dllimport static field" error to warning for class templates (PR19902)
ClosedPublic

Authored by hans on Jun 2 2014, 7:36 PM.

Details

Summary

This allows us to compile the following kind of code, which occurs in MSVC headers:

template <typename> struct S {
  __declspec(dllimport) static int x;
};
template <typename T> int S<T>::x;

Please take a look.

Diff Detail

Repository
rL LLVM

Event Timeline

hans updated this revision to Diff 10038.Jun 2 2014, 7:36 PM
hans retitled this revision from to Downgrade "definition of dllimport static field" error to warning for class templates (PR19902).
hans updated this object.
hans edited the test plan for this revision. (Show Details)
hans added reviewers: nrieck, rnk.
hans added subscribers: Unknown Object (MLST), hansw.
hans updated this revision to Diff 10069.Jun 3 2014, 4:20 PM

Uploading new version of the patch.

rnk accepted this revision.Jun 3 2014, 5:01 PM
rnk edited edge metadata.

lgtm

Alp's suggested 'IsInvalid' renaming seems reasonable.

This revision is now accepted and ready to land.Jun 3 2014, 5:01 PM
hans closed this revision.Jun 3 2014, 5:26 PM
hans updated this revision to Diff 10072.

Closed by commit rL210141 (authored by @hans).